Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tides malfunctions in version 7.0beta #19807

Closed
miguelmarco opened this issue Dec 30, 2015 · 16 comments
Closed

Tides malfunctions in version 7.0beta #19807

miguelmarco opened this issue Dec 30, 2015 · 16 comments

Comments

@miguelmarco
Copy link
Contributor

As was pointed in #19781, tides_mpfr does not work properly in the last beta.

I could trace the problem to the loading of libgmp. I attach a branch that seems to fix it, but it could be that now it is using system's libgmp/libmpfr .

Can somebody test it in a platform without libgmp installed system wide?

CC: @vbraun @jdemeyer

Component: packages: optional

Keywords: tides

Author: Miguel Marco

Branch: 0396add

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/19807

@miguelmarco miguelmarco added this to the sage-7.0 milestone Dec 30, 2015
@miguelmarco
Copy link
Contributor Author

@miguelmarco
Copy link
Contributor Author

Changed keywords from none to tides

@miguelmarco
Copy link
Contributor Author

Author: Miguel Marco

@miguelmarco

This comment has been minimized.

@miguelmarco
Copy link
Contributor Author

Commit: 12c3e8a

@miguelmarco
Copy link
Contributor Author

New commits:

12c3e8aDon't use -L and -I flags

@jdemeyer
Copy link

comment:3

You most likely just need to add $LDFLAGS to the command line.

@miguelmarco
Copy link
Contributor Author

comment:5

You mean during the compilation of the library, the compilation of each instance or at running it?

@jdemeyer
Copy link

comment:6

I mean in the command line that you changed in your patch.

@vbraun
Copy link
Member

vbraun commented Dec 30, 2015

comment:7

You can just test it using ldd /path/to/binary

You should always add $LDFLAGS when creating a binary. That includes shared libraries.

Static libraries (libtides.a) aren't executable so you don't need $LDFLAGS.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 30, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

6981184Added $LDFLAGS
0396addPut -L directive before -l

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 30, 2015

Changed commit from 12c3e8a to 0396add

@miguelmarco
Copy link
Contributor Author

comment:9

I think it is fixed now.

@vbraun
Copy link
Member

vbraun commented Dec 30, 2015

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Dec 30, 2015

Changed branch from u/mmarco/tides_malfunctions_in_version_7_0beta to 0396add

@slel
Copy link
Member

slel commented Apr 16, 2020

Changed commit from 0396add to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants