Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the results of monoid_generators for IndexedFreeMonoid #19829

Closed
tscrim opened this issue Jan 4, 2016 · 7 comments
Closed

Cache the results of monoid_generators for IndexedFreeMonoid #19829

tscrim opened this issue Jan 4, 2016 · 7 comments
Assignees
@sagetrac-sage-combinat
Labels
p: major / 3 t: bug t: performance
Milestone
sage-7.0

Comments

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2016

We should cache this because it can be relatively expensive to compute and I have a few tight loops where this becomes a major slowdown.

CC: @sagetrac-sage-combinat @nthiery @darijgr

Component: performance

Author: Travis Scrimshaw

Branch/Commit: 0020e67

Reviewer: Darij Grinberg

Issue created by migration from https://trac.sagemath.org/ticket/19829
@tscrim tscrim added this to the sage-7.0 milestone Jan 4, 2016
@tscrim
Copy link
Collaborator Author

tscrim commented Jan 4, 2016

Branch: public/monoids/cache_indexed_monoid_generators-19829

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 4, 2016

New commits:

0020e67Cache the monoid (resp. group) generators for the indexed free monoid (resp. group).

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 4, 2016

Commit: 0020e67

@darijgr
Copy link
Contributor

darijgr commented Jan 12, 2016

comment:3

LGTM (which, at this length, is little surprising :) ).

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 12, 2016

comment:4

Thanks!

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 12, 2016

Reviewer: Darij Grinberg

@vbraun
Copy link
Member

vbraun commented Jan 12, 2016

Changed branch from public/monoids/cache_indexed_monoid_generators-19829 to 0020e67

@vbraun vbraun closed this as completed in e177659 Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-sage-combinat sagetrac-sage-combinat

Labels
p: major / 3 t: bug t: performance
Projects
None yet
Milestone
sage-7.0
Development

No branches or pull requests
3 participants
@vbraun @tscrim @darijgr