Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure NTL without NTL_LEGACY_SP_MULMOD=on #19874

Closed
jpflori opened this issue Jan 12, 2016 · 13 comments
Closed

Configure NTL without NTL_LEGACY_SP_MULMOD=on #19874

jpflori opened this issue Jan 12, 2016 · 13 comments

Comments

@jpflori
Copy link

jpflori commented Jan 12, 2016

There is an issue with bernmm which prevents this.
For every even number from 128, the result of

bernoulli(n, algorithm='bernmm')

is wrong.

This is because some modular multiplication mod n is made with inputs larger than n which is not supported by NTL (as documented).

CC: @jdemeyer

Component: packages: standard

Keywords: ntl

Author: Jean-Pierre Flori

Branch/Commit: b0071e0

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/19874

@jpflori jpflori added this to the sage-7.0 milestone Jan 12, 2016
@jpflori
Copy link
Author

jpflori commented Jan 12, 2016

New commits:

b868e29Use new NTL sp_mulmod code.

@jpflori
Copy link
Author

jpflori commented Jan 12, 2016

Author: Jean-Pierre Flori

@jpflori
Copy link
Author

jpflori commented Jan 12, 2016

Commit: b868e29

@jpflori
Copy link
Author

jpflori commented Jan 12, 2016

Changed keywords from none to ntl

@jpflori

This comment has been minimized.

@jpflori
Copy link
Author

jpflori commented Jan 12, 2016

Branch: u/jpflori/ticket/19874

@jdemeyer
Copy link

comment:2

NTL version number should be increased.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2016

Changed commit from b868e29 to 34d9148

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

f711459Bump NTL version to force a rebuild.
34d9148Add additional minimal previously failing test for new NTL + unmodified bernmm.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b0071e0Fix indentation of NTL+bernmm test.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2016

Changed commit from 34d9148 to b0071e0

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Jan 20, 2016

Changed branch from u/jpflori/ticket/19874 to b0071e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants