remove misleading line in FormalSums

[mantepse]

As discussed in this sage-devel discussion, the "elif" branch in this excerpt can never be visited, since if its condition was satisfied, the "if" condition would have been too, and the method would have ended with the "return" statement in the "if" branch.

class FormalSums(UniqueRepresentation, Module):

    Element = FormalSum

    def _element_constructor_(self, x, check=True, reduce=True):

        if isinstance(x, FormalSum):
            P = x.parent()
            if P is self:
                return x
            elif P == self:
                return self.element_class(x._data, check=False, reduce=False, parent=self)
            else:
                x = x._data

We therefore remove the "elif" branch which can only cause confusion.

Component: algebra

Author: Martin Rubey

Branch/Commit: fc1a04f

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/19886

[mantepse]

Branch: u/mantepse/remove_misleading_line_in_formalsums

[mantepse]

Author: Martin Rubey

[mantepse]

Changed branch from u/mantepse/remove_misleading_line_in_formalsums to none

[mantepse]

Branch: u/mantepse/remove_misleading_line_in_formalsums

[dkrenn]

Reviewer: Daniel Krenn

[dkrenn]

Commit: fc1a04f

[dkrenn]

comment:4

LGTM

---

New commits:

fc1a04f

remove confusing line

[slel]

comment:5

Can you summarize in one line in the ticket description what this ticket is about?
Why was the line misleading, why removing it is making Sage better?

[mantepse]

comment:6

See this thread on sage-devel:

https://groups.google.com/forum/#!topic/sage-devel/09Xf1_coMOc

[vbraun]

Changed branch from u/mantepse/remove_misleading_line_in_formalsums to fc1a04f