Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution of S-unit equations over Q #19887

Open
JohnCremona opened this issue Jan 14, 2016 · 15 comments
Open

Solution of S-unit equations over Q #19887

JohnCremona opened this issue Jan 14, 2016 · 15 comments

Comments

@JohnCremona
Copy link
Member

Angelos Koutsianas has written code to solve general 3-term S-unit equations over Q, i.e. to find all solutions to x+y=1 where x,y are rationals supported on the primes in a given finite set S. This is based on de Weger's thesis.

The code is currently being tested, and will be made into a new branch here.

CC: @sagetrac-akoutsianas

Component: number theory

Keywords: S-unit equation

Author: Angelos Koutsianas, John Cremona

Branch/Commit: u/mwest/19887 @ 1f4de5b

Issue created by migration from https://trac.sagemath.org/ticket/19887

@JohnCremona JohnCremona added this to the sage-7.0 milestone Jan 14, 2016
@JohnCremona
Copy link
Member Author

Branch: u/cremona/19887

@JohnCremona
Copy link
Member Author

Commit: 64b0e74

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 4, 2016

Changed commit from 64b0e74 to f97b22f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 4, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b1709e9Merge branch 'develop' into S_unit
f97b22fremove redundant import from S_unit.py which caused startup crash

@JohnCremona
Copy link
Member Author

comment:4

The above commit (f97b22f) includes 7.1.beta1, and the new file passes its tests.

@JohnCremona
Copy link
Member Author

comment:5

I think we need to added the new file S_unit_equation.py to the reference manual, and I will try to do that. Also, the file aith.py was moved and I am not sure that the reference manual has been adjusted correctly.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 4, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

42d9788progress on documentation of S-unit code

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 4, 2016

Changed commit from f97b22f to 42d9788

@JohnCremona
Copy link
Member Author

comment:7

Docs now build without errors, I will work on the text a bit.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 5, 2016

Changed commit from 42d9788 to d0fb02b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 5, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

d0fb02bfix some docstring formatting in S-unit eqn code

@JohnCremona
Copy link
Member Author

comment:9

The docstrings now look OK, though perhaps not all functions are explained adequately (and the specific reference should be checked as I was not sure which were to Smart and which to de Weger). I am finished with this code for now.

@mckenziewest
Copy link

Changed branch from u/cremona/19887 to u/mwest/19887

@mkoeppe mkoeppe removed this from the sage-7.1 milestone Dec 29, 2022
@JohnCremona
Copy link
Member Author

Changed commit from d0fb02b to 1f4de5b

@JohnCremona
Copy link
Member Author

comment:12

This ticket became obsolete as the work was done at #22148, merged in version 8.5.


New commits:

3934d22updated code moved to number_field directory
1f4de5bremove solver from arith directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants