Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant imports of ParentWithGens/ParentWithBase #19934

Closed
jdemeyer opened this issue Jan 21, 2016 · 8 comments
Closed

Remove redundant imports of ParentWithGens/ParentWithBase #19934

jdemeyer opened this issue Jan 21, 2016 · 8 comments
Labels
p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@jdemeyer
Copy link

While grepping the Sage source code to see where the old ParentWithGens/ParentWithBase is still used, I noticed various places where it's imported but unused or where its use can easily be replaced by Parent.

Component: misc

Author: Jeroen Demeyer

Branch/Commit: 8a69e19

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19934
@jdemeyer jdemeyer added this to the sage-7.1 milestone Jan 21, 2016
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Remove redundant imports of ParentWithGens Remove redundant imports of ParentWithGens/ParentWithBase Jan 21, 2016
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/remove_redundant_imports_of_parentwithgens

@jdemeyer
Copy link
Author

Commit: 8a69e19

@jdemeyer
Copy link
Author

New commits:

8a69e19Remove redundant uses of ParentWithBase and ParentWithGens

@tscrim
Copy link
Collaborator

tscrim commented Jan 21, 2016

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 21, 2016

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jan 24, 2016

Changed branch from u/jdemeyer/remove_redundant_imports_of_parentwithgens to 8a69e19

@vbraun vbraun closed this as completed in d0d99f0 Jan 24, 2016
@jdemeyer jdemeyer mentioned this issue Jan 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer