Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rings/commutative_ring.py and friends #20011

Closed
jdemeyer opened this issue Feb 5, 2016 · 7 comments
Closed

Deprecate rings/commutative_ring.py and friends #20011

jdemeyer opened this issue Feb 5, 2016 · 7 comments
Labels
p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@jdemeyer
Copy link

jdemeyer commented Feb 5, 2016

The following modules contain only is_... functions and should be removed:

sage/rings/commutative_ring.py
sage/rings/dedekind_domain.py
sage/rings/euclidean_domain.py
sage/rings/integral_domain.py
sage/rings/principal_ideal_domain.py

Component: misc

Author: Jeroen Demeyer

Branch/Commit: d200bac

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20011
@jdemeyer jdemeyer added this to the sage-7.1 milestone Feb 5, 2016
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

jdemeyer commented Feb 5, 2016

Branch: u/jdemeyer/deprecate_rings_commutative_ring_py_and_friends

@jdemeyer
Copy link
Author

jdemeyer commented Feb 5, 2016

Commit: d200bac

@jdemeyer
Copy link
Author

jdemeyer commented Feb 5, 2016

New commits:

d200bacDeprecate rings/commutative_ring.py and friends

@tscrim
Copy link
Collaborator

tscrim commented Feb 5, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 5, 2016

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Feb 6, 2016

Changed branch from u/jdemeyer/deprecate_rings_commutative_ring_py_and_friends to d200bac

@vbraun vbraun closed this as completed in f36e7f6 Feb 6, 2016
@jdemeyer jdemeyer mentioned this issue Apr 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer