Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage_bootstrap: Remove purported Python 2.6 support #20023

Closed
vbraun opened this issue Feb 7, 2016 · 55 comments
Closed

sage_bootstrap: Remove purported Python 2.6 support #20023

vbraun opened this issue Feb 7, 2016 · 55 comments

Comments

@vbraun
Copy link
Member

vbraun commented Feb 7, 2016

In this ticket, we

This is on top of #31419 so that we have to change README only once.

Depends on #29890
Depends on #31419
Depends on #31318

CC: @fchapoton @dimpase @embray @kiwifb @jdemeyer @slel @jhpalmieri

Component: build

Author: Dima Pasechnik, Matthias Koeppe

Branch/Commit: 8cd0bcc

Reviewer: Matthias Koeppe, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/20023

@vbraun vbraun added this to the sage-7.1 milestone Feb 7, 2016
@karandesai-96
Copy link
Mannequin

karandesai-96 mannequin commented Feb 9, 2016

comment:1

I changed the directory to SAGE_ROOT/build/sage_bootstrap and checked out contents :
`
.
├── cksum.py
├── cmdline.py
├── compat.py
├── config.py
├── download.py
├── env.py
├── init.py
├── levenshtein.py
├── logger.py
├── mirror_list.py
├── package.py
├── README
├── stdio.py
├── tarball.py
└── updater.py

`

There is no subdirectory named "compat".

@embray
Copy link
Contributor

embray commented Feb 24, 2016

comment:2

This can also help with #9536 since Python 2.7+ supports the --no-user-cfg option to setup.py/setup.cfg, which Python 2.6 does not (just thought of this since it's an issue I looked at recently).

@vbraun
Copy link
Member Author

vbraun commented Jun 11, 2016

Dependencies: #19984

@vbraun

This comment has been minimized.

@vbraun vbraun changed the title Remove Python 2.6 support Remove Python 2.6 support at some future point Jun 11, 2016
@nexttime nexttime mannequin removed this from the sage-7.1 milestone Jul 1, 2016
@nexttime nexttime mannequin added wishlist item and removed t: enhancement labels Jul 1, 2016
@slel
Copy link
Member

slel commented Jun 16, 2019

comment:5

See #28000 for complete removal of Python 2 support.

@embray
Copy link
Contributor

embray commented Jun 17, 2019

comment:6

I'm pretty sure Python 2.6 support is completely removed from sagelib itself, just not from sage_bootstrap.

@dimpase
Copy link
Member

dimpase commented Jun 18, 2019

comment:7

should we clean up sage_bootstrap in this respect here? (this would mean to require system's Python 2.7 or better for building)

@slel
Copy link
Member

slel commented Jun 19, 2019

comment:8

Removing the ability to bootstrap from Python 2.6 probably does
not need to happen before we remove Python 2 support in sagelib.

@dimpase
Copy link
Member

dimpase commented Jun 19, 2019

comment:9

From the brief look at the code, this is a change that may be done now, and after all noone must Python 2.6 now.

@kiwifb
Copy link
Member

kiwifb commented Jun 19, 2019

comment:10

It's the default python on redhat/centos 6 and possibly some ancient debian. I'll note that redhat/centos 6 have access to newer python but someone with admin privileges and knowledge of software collections is needed.

@mkoeppe mkoeppe changed the title Remove Python 2.6 support at some future point sage_bootstrap: Remove Python 2.6 support at some future point Jun 18, 2020
@dimpase
Copy link
Member

dimpase commented Jun 18, 2020

comment:12

I'll make an experimental branch to remove vendored argparse

@dimpase
Copy link
Member

dimpase commented Jun 18, 2020

Author: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jun 18, 2020

Commit: 2d0891d

@dimpase
Copy link
Member

dimpase commented Jun 18, 2020

Branch: u/dimpase/build/unvendorargparse

@dimpase
Copy link
Member

dimpase commented Jun 18, 2020

New commits:

2d0891dremove vendored argparse

@dimpase
Copy link
Member

dimpase commented Jun 18, 2020

Changed dependencies from #19984 to none

@dimpase
Copy link
Member

dimpase commented Jun 18, 2020

comment:14

tests run on https://github.com/dimpase/sage/pull/11

@mkoeppe
Copy link
Member

mkoeppe commented Jun 18, 2020

comment:16

Also need to update build/tox.ini

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 18, 2020

Changed commit from 2d0891d to f734c8e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 18, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

f734c8eremove py26 from tox

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 4, 2021

Changed commit from 0f3d369 to 86c05e6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5e810ddbuild/pkgs/python3: Update to 3.9.2
60d6433Merge #31419
06873c2README.md: Update Python requirement for build

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 4, 2021

Changed commit from 86c05e6 to 06873c2

@mkoeppe
Copy link
Member

mkoeppe commented Mar 4, 2021

Changed dependencies from #29890 to #29890, #31419

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member

mkoeppe commented Mar 4, 2021

Changed reviewer from Matthias Koeppe to Matthias Koeppe, ...

@dimpase
Copy link
Member

dimpase commented Mar 4, 2021

comment:39

should we also remove py33 from build/tox.ini ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c948b02build/tox.ini: Remove py33, add py39, py310

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 4, 2021

Changed commit from 06873c2 to c948b02

@dimpase
Copy link
Member

dimpase commented Mar 5, 2021

comment:41

OK, this works

@dimpase
Copy link
Member

dimpase commented Mar 5, 2021

Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, Dima Pasechnik

@mkoeppe
Copy link
Member

mkoeppe commented Mar 5, 2021

comment:42

Thanks.

@vbraun
Copy link
Member Author

vbraun commented Mar 8, 2021

comment:43

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2021

Changed commit from c948b02 to b1fe929

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

92533b8Merge tag '9.3.beta8' into t/20023/build/unvendorargparse
0cac965build/pkgs/ecl: Update to 21.2.1, remove patches included in new version
6a62484delete all merged upstream patches: MR 210, MR 231
b1fe929Merge #31336

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6ef52d6build/pkgs/python3/spkg-configure.m4: Issue a deprecation warning for system python 3.6
cf55561Merge branch 't/31192/installation_manual__fix_documentation_of_python_prerequisite__sage_bootstrap_python_' into t/31318/python3_spkg_configure_m4__add_deprecation_warning_regarding_system_python_3_6
0fb8646README.md, src/doc/en/installation/source.rst: Mention/update version range for python3
8cd0bccMerge #31318

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2021

Changed commit from b1fe929 to 8cd0bcc

@mkoeppe
Copy link
Member

mkoeppe commented Mar 8, 2021

Changed dependencies from #29890, #31419 to #29890, #31419, #31318

@vbraun
Copy link
Member Author

vbraun commented Mar 14, 2021

Changed branch from u/mkoeppe/build/unvendorargparse to 8cd0bcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants