Enable thickness-option in graph plotting

[jm58660]

This trivial patch allows thickness-option in graph plotting. It seems to have forgotten from the option list.

To test try for example

G = graphs.CompleteGraph(4)
G.allow_loops(True)
G.allow_multiple_edges(True)
G.set_edge_label(1,3,'foo')
G.set_edge_label(1,0,'foo')
G.add_edge(1,1)
G.add_edge(1,3)
G.show(color_by_label=True, edge_thickness=2.5)

CC: @anneschilling @fchapoton @slel

Component: graphics

Author: Jori Mäntysalo

Branch: 674361a

Reviewer: Paul Masson

Issue created by migration from https://trac.sagemath.org/ticket/20035

[jm58660]

Branch: u/jmantysalo/graph_plotting_thickness

[jm58660]

New commits:

908f9b9

Enable thickness-option in graph plotting.

[jm58660]

Commit: 908f9b9

[nathanncohen]

comment:3

I am wondering about the name: vertex_colors, edge_colors, why not edge_thickness to go with them?

Nathann

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

55ab51a

From 'thickness' to 'edge_thickness'.

[sagetrac-git]

Changed commit from 908f9b9 to 55ab51a

[jm58660]

comment:5

Replying to @nathanncohen:

I am wondering about the name: vertex_colors, edge_colors, why not edge_thickness to go with them?

True. Changed.

[nathanncohen]

comment:6

Okay, cool !

I just noticed that the list of arguments is also available in GenericGraph.plot. That's an ugly copy/paste, that's for sure... I'm hesitant to remove it and link toward the auto-generated doc of the graph_plot module, however: what do you think?

Nathann

[nathanncohen]

comment:7

(adding Anne in case she cares: she mentionned the options of Graph.plot some time ago)

[jm58660]

comment:8

Replying to @nathanncohen:

I just noticed that the list of arguments is also available in GenericGraph.plot. That's an ugly copy/paste, that's for sure... I'm hesitant to remove it and link toward the auto-generated doc of the graph_plot module, however: what do you think?

I think that #13827 is what we really need. This is phase zero, enabling features that are already there.

[anneschilling]

comment:9

What I recently wished existed was the following: internally the vertices are labelled by something. I wanted to be able to give a function f from the internal labels to some other labels (for printing). The printing labels would not necessarily need to distinct for all vertices (i.e. it could be a non-injective map). If x is an internal label, the plot would print f(x) next to the label.

Would this be easy to add?

[nathanncohen]

comment:10

Would this be easy to add?

Yes it is. This kind of code would be very similar to the other options already available, so you need not fear to hit a block if you give it a try.

[jm58660]

comment:11

Ticket #15206 is about non-injective relabeling. Please add your code under it.

[jm58660]

comment:12

Frédéric, got some minutes? This one is should be trivial.

[paulmasson]

Reviewer: Paul Masson

[paulmasson]

comment:13

Eight doctests failed: please fix them.

Also, in the documentation "tickness" needs to be corrected to "thickness".

[sagetrac-git]

Changed commit from 55ab51a to 674361a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

674361a

Add thickness to list of options.

[jm58660]

comment:16

OK, now the errors seem to be gone.

[paulmasson]

comment:17

Doctests pass. Documentation builds. Example runs as expected.

[vbraun]

Changed branch from u/jmantysalo/graph_plotting_thickness to 674361a

[slel]

comment:19

See also #6546, #21540.

[slel]

Changed commit from 674361a to none