Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Singularity analysis method for log-type singularities #20040

Closed
cheuberg opened this issue Feb 11, 2016 · 21 comments
Closed

Singularity analysis method for log-type singularities #20040

cheuberg opened this issue Feb 11, 2016 · 21 comments
Labels
c: asymptotic expansions p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@cheuberg
Copy link
Contributor

Enhance #19944 to deal with log-type singularities.

Depends on #19944
Depends on #20020

CC: @dkrenn @behackl

Component: asymptotic expansions

Keywords: singularity analysis

Author: Clemens Heuberger

Branch/Commit: 8bb9046

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/20040
@cheuberg cheuberg added this to the sage-7.1 milestone Feb 11, 2016
@cheuberg
Copy link
Contributor Author

Branch: u/cheuberg/asy/singularity-analysis-method-log

@cheuberg
Copy link
Contributor Author

Last 10 new commits:

7c1d207Trac #19944: rewrite singularity analysis to use method of terms
5c66050Trac #19944: be more explicit w.r.t. parameter function
637147cTrac #19944: merge latest version of #19993
bfd8f2fMerge branch 't/19944/asy/singularity-analysis-method' into asy/singularity-analysis-method-log
44515f6Trac #20040: method gens_logarithmic
c8665a2Trac #20040: singularity analysis for terms log(n)^k
76f0b74Trac #20040: singularity analysis for cartesian products with one factor
4a95037Trac #20040: singularity analysis method allows single logs
6f595eeTrac #20040: Singularity analysis of two factors
6b81bffTrac #20040: additional doctest (harmonic numbers)

@cheuberg
Copy link
Contributor Author

Commit: 6b81bff

@dkrenn
Copy link
Contributor

dkrenn commented Feb 12, 2016

Changed branch from u/cheuberg/asy/singularity-analysis-method-log to u/dkrenn/asy/singularity-analysis-method-log

@cheuberg
Copy link
Contributor Author

Changed commit from 6b81bff to b6ffdaa

@cheuberg
Copy link
Contributor Author

comment:4

cross-reviewed your changes.

Last 10 new commits:

33f675dMerge branch 'u/dkrenn/asy/one-times-zero' of trac.sagemath.org:sage into t/19969/asy/SA-generator-log
a9e618eMerge branch 'u/dkrenn/asy/SA-generator-log' of trac.sagemath.org:sage into t/19944/asy/singularity-analysis-method
98e1fc7Trac #20043: make error message more precise and flexibel
99d7292Merge branch 't/20043/asy/one-times-zero' into t/19969/asy/SA-generator-log
dd7dabfTrac #19969: fix doctest
88f278dMerge branch 't/19969/asy/SA-generator-log' into HEAD
46d91b3Trac #19944: fix doctests and code
0624f6aMerge branch 'u/dkrenn/asy/singularity-analysis-method' of trac.sagemath.org:sage into t/20040/asy/singularity-analysis-method-log
a9ec510Trac #20040: extend NotImplementedOZero to allow passing var directly
b6ffdaaTrac #20040: fix doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 14, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

617e5bfTrac #19969: rewrite output of doctest so that comparison with Formula in Flajolet-Sedgewick is easier
456d8c3Trac #19969: correct whitespaces
b540598Trac #19969: add an additional doctest
984ca4dMerge branch 'u/dkrenn/asy/SA-generator-log' of git://trac.sagemath.org/sage into t/19944/asy/singularity-analysis-method
e1e2ef3Trac #19944: minor restructure of code
97249e7Trac #19944: minor improvement of docstrings (whitespaces, punctation, ...)
ad62c31Trac #19944: show element in NotImplementedError
abf2b7aMerge branch 'u/dkrenn/asy/singularity-analysis-method' of git://trac.sagemath.org/sage into t/20040/asy/singularity-analysis-method-log
a6a844fTrac #20040: fix doctests after merge of #19944

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 14, 2016

Changed commit from b6ffdaa to a6a844f

@cheuberg
Copy link
Contributor Author

comment:6

I cross-reviewed your changes so far and will now merge the newest version of #19944 and continue the changes (order of parameters, named parameter precision) here.

@cheuberg
Copy link
Contributor Author

Changed branch from u/dkrenn/asy/singularity-analysis-method-log to u/cheuberg/asy/singularity-analysis-method-log

@cheuberg
Copy link
Contributor Author

Changed commit from a6a844f to d0f5e94

@cheuberg
Copy link
Contributor Author

comment:8

Replying to @cheuberg:

I cross-reviewed your changes so far and will now merge the newest version of #19944 and continue the changes (order of parameters, named parameter precision) here.

Done.

New commits:

9ce7b35Trac #19944: exchange order of parameters var and zeta in _singularity_analysis_
902c182Trac #20040: Merge #19944
866a9e3Trac #20040: exchange order of parameters var and zeta in _singularity_analysis_
c79a6f7Trac #19944: exchange zeta and var in docstrings
d0f5e94Trac #20040: Merge #19944

@dkrenn
Copy link
Contributor

dkrenn commented Feb 14, 2016

Changed branch from u/cheuberg/asy/singularity-analysis-method-log to u/dkrenn/asy/singularity-analysis-method-log

@dkrenn
Copy link
Contributor

dkrenn commented Feb 14, 2016

comment:10

I've finished my review and cross-reviewed your latest changes. I've also added a couple of small commits which need a cross-review. If ok, then feel free to give this ticket a positive review.

New commits:

1ed6067Merge branch 'u/dkrenn/asy/SA-generator-log' of trac.sagemath.org:sage into t/20020/asy/singularity-generator-log-non-normalized
931e5dfMerge branch 'u/dkrenn/asy/SA-generator-log' of git://trac.sagemath.org/sage into t/20020/asy/singularity-generator-log-non-normalized
4462b27Trac #20020: correct whitespaces
60790f5Merge branch 'u/dkrenn/asy/singularity-generator-log-non-normalized' of git://trac.sagemath.org/sage into t/20040/asy/singularity-analysis-method-log
1276422Trac #20040: whitespaces
5e9cffbTrac # 20040: unify NotImplementedError-message
a1c4498Trac #20040: minor code rewrite for readability
4dae56dTrac #20040: unify all NotImplementedError-messages
27a8605Merge branch 'u/cheuberg/asy/singularity-analysis-method-log' of git://trac.sagemath.org/sage into t/20040/asy/singularity-analysis-method-log

@dkrenn
Copy link
Contributor

dkrenn commented Feb 14, 2016

Changed commit from d0f5e94 to 27a8605

@cheuberg
Copy link
Contributor Author

Changed branch from u/dkrenn/asy/singularity-analysis-method-log to u/cheuberg/asy/singularity-analysis-method-log

@cheuberg
Copy link
Contributor Author

Changed commit from 27a8605 to 8bb9046

@cheuberg
Copy link
Contributor Author

comment:12

Replying to @dkrenn:

I've finished my review and cross-reviewed your latest changes. I've also added a couple of small commits which need a cross-review. If ok, then feel free to give this ticket a positive review.

cross-reviewed. Added another two commits which need a brief review.

New commits:

452c43bTrac #19944: `_singularity_analysis_` methods: more precise documentation
4cb5934Trac #20040: Merge #19944
8455dc2Trac #20040: `_singularity_analysis_` methods: more precise documentation
8bb9046Trac #20040: added myself to AUTHORS

@dkrenn
Copy link
Contributor

dkrenn commented Feb 14, 2016

comment:13

Replying to @cheuberg:

cross-reviewed. Added another two commits which need a brief review.

Fine.

@dkrenn
Copy link
Contributor

dkrenn commented Feb 14, 2016

Reviewer: Daniel Krenn

@vbraun
Copy link
Member

vbraun commented Feb 16, 2016

Changed branch from u/cheuberg/asy/singularity-analysis-method-log to 8bb9046

@vbraun vbraun closed this as completed in bd5079b Feb 16, 2016
@behackl behackl mentioned this issue Dec 29, 2022
Open
This was referenced Dec 29, 2022
Open
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: asymptotic expansions p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @cheuberg @dkrenn