Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade the sage notebook #20047

Closed
kiwifb opened this issue Feb 14, 2016 · 27 comments
Closed

upgrade the sage notebook #20047

kiwifb opened this issue Feb 14, 2016 · 27 comments

Comments

@kiwifb
Copy link
Member

kiwifb commented Feb 14, 2016

#20030, #20016 and #20094 need a matching change in sagenb.

Upstream package is at http://sage.ugent.be/www/jdemeyer/sage/sagenb-0.11.7.tar

CC: @kcrisman

Component: packages: standard

Author: Karl-Dieter Crisman

Branch/Commit: a77ff01

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/20047

@jdemeyer

This comment has been minimized.

@kcrisman
Copy link
Member

comment:3

Don't have any more time tonight but I've merged all the things in question and will package soon. Sorry for some extra merge commits, btw.

@jdemeyer

This comment has been minimized.

@kcrisman
Copy link
Member

Branch: u/kcrisman/ticket/20047

@kcrisman
Copy link
Member

New commits:

c1e219aUpgrade sagenb to version 0.11.7

@kcrisman
Copy link
Member

Commit: c1e219a

@kcrisman

This comment has been minimized.

@kcrisman
Copy link
Member

Author: Karl-Dieter Crisman

@kcrisman
Copy link
Member

comment:7

I think I did everything correctly, try it out! Be sure to test that the notebook help works etc.

@jdemeyer
Copy link

Changed branch from u/kcrisman/ticket/20047 to u/jdemeyer/ticket/20047

@jdemeyer
Copy link

Changed commit from c1e219a to 6e0cdc0

@jdemeyer
Copy link

comment:9

Merged #20030 in the branch.


New commits:

f3d7236SAGE_DOC -> SAGE_DOC_SRC and SAGE_DOC_OUTPUT -> SAGE_DOC
1667635Ignore errors in symlinking
56ea5efMissing a SAGE_DOC_SRC in sagedoc.py
6e0cdc0Merge remote-tracking branch 'trac/u/fbissey/SAGE_DOC_SRC' into t/20047/ticket/20047

@jdemeyer
Copy link

comment:10

It doesn't install for me:

Processing dependencies for Flask-AutoIndex==0.6
Searching for future>=0.13.0

Note: Bypassing https://pypi.python.org/simple/future/ (disallowed host; see http://bit.ly/1dg9ijs for details).

Couldn't find index page for 'future' (maybe misspelled?)
Scanning index of all packages (this may take a while)

Note: Bypassing https://pypi.python.org/simple/ (disallowed host; see http://bit.ly/1dg9ijs for details).

No local packages or download links found for future>=0.13.0
error: Could not find suitable distribution for Requirement.parse('future>=0.13.0')
Error: Installing Flask-AutoIndex-0.6.tar.gz failed.

@kiwifb
Copy link
Member Author

kiwifb commented Feb 23, 2016

comment:11

Looks like the dependencies weren't packaged properly or something was included that shouldn't. For future I am guessing we are talking about http://python-future.org/.

@jdemeyer
Copy link

comment:12

Flask-AutoIndex was upgraded from 0.5 to 0.6. Is that upgrade required? If not, reverting it might solve this problem.

@kiwifb
Copy link
Member Author

kiwifb commented Feb 23, 2016

comment:13

Compared to 0.11.6.1 I think all the dependency upgrade are gratuitous. All that was merged are the PR for the tickets in the summary. Sure it is good to keep on top but I don't think any of them are strictly necessary.

@kcrisman
Copy link
Member

comment:14

No, no upgrades are required. But I don't know exactly how to (automatically, that is) revert such things. I guess I can do it manually by unpacking a previous tarball. I think that the dist.sh script just downloads whatever the most recent version is. I won't have time tomorrow for this, though.

@jdemeyer
Copy link

comment:15

I can repackage sagenb-0.11.7 by reverting to Flask-AutoIndex-0.5

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2016

Changed commit from 6e0cdc0 to a77ff01

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 24, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

a77ff01Repackage sagenb with Flask-AutoIndex-0.5

@jdemeyer
Copy link

comment:18

Sorry, still doesn't work.

@jdemeyer
Copy link

comment:19

It does work. However, if you tested an old version of this ticket, you need to delete the previous installation of Flask-AutoIndex or you need make distclean.

@jdemeyer
Copy link

comment:20

Just tested it and SageNB seems to work fine.

I did find a serious bug sagemath/sagenb#368 but given that it's also in the current sagenb, it shouldn't block this ticket.

@vbraun
Copy link
Member

vbraun commented Feb 25, 2016

Changed dependencies from #20030 to none

@vbraun
Copy link
Member

vbraun commented Feb 25, 2016

Changed branch from u/jdemeyer/ticket/20047 to a77ff01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants