minimal periodic points code improvement

[bhutz]

In projective morphism the code block for minimal periodic points around line 3003

        if not minimal:
            return points
        else:
            rem_indices = []
            for i in range(len(points)-1,-1,-1):
                # iterate points to check if minimal
                P = points[i]
                for j in range(1,n):
                    P = self(P)
                    if P == points[i]:
                        points.pop(i)
                        break
            return points

has an unused list and could use some additional comments to explain what this is doing.

CC: @sagetrac-gjorgenson

Component: algebraic geometry

Author: Ben Hutz

Branch: 3c9adc3

Reviewer: Rebecca Lauren Miller

Issue created by migration from https://trac.sagemath.org/ticket/20059

[bhutz]

Branch: u/bhutz/ticket/20059

[bhutz]

Commit: 3c9adc3

[bhutz]

comment:2

In addition to adding the documentation to the minimal section I made three improvements to the function

• allowed the user to pass in a ring where the points should be defined

• extended the functionality to include finite fields

• allowed the user to choose the method used

---

New commits:

3c9adc3

20059: improvement to projective periodic_points function

[bhutz]

Author: Ben Hutz

[sagetrac-rlmiller]

Reviewer: Rebecca Miller

[sagetrac-rlmiller]

comment:4

Looks good to me.

[vbraun]

Changed branch from u/bhutz/ticket/20059 to 3c9adc3

[jdemeyer]

Changed commit from 3c9adc3 to none

[jdemeyer]

comment:6

What do you prefer: "Rebecca Lauren Miller" or "Rebecca Miller"?

[sagetrac-rlmiller]

Changed reviewer from Rebecca Miller to Rebecca Lauren Miller