Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken spyx support concerning imports #20093

Closed
dkrenn opened this issue Feb 22, 2016 · 10 comments
Closed

broken spyx support concerning imports #20093

dkrenn opened this issue Feb 22, 2016 · 10 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Feb 22, 2016

File problem.spyx with

import sage.all
from sage.all import *
from sage.rings.integer_ring import ZZ
print ZZ(1000)

Run it with sage problem.spyx and it fails with

ImportError: cannot import name ZZ

on 6.9, 6.10, 7.0, 7.1.beta4.

See also discussion https://groups.google.com/forum/#!topic/sage-support/NcQ2Lgj_oao

Depends on #20002

Component: scripts

Author: Jeroen Demeyer

Branch/Commit: f87fa19

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/20093

@dkrenn dkrenn added this to the sage-7.1 milestone Feb 22, 2016
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

Dependencies: #20002

@jdemeyer
Copy link

Author: Jeroen Demeyer

@jdemeyer
Copy link

Branch: u/jdemeyer/ticket/20093

@jdemeyer
Copy link

Commit: f87fa19

@jdemeyer
Copy link

New commits:

fc69b52Move interrupt.pyx to package cysignals
aee6a5fCheck that sig_on()/sig_off() works in .spyx files
434b272cysignals depends on PARI
f663c5dSage library depends on cysignals
4677a93cysignals version 1.0rc2
f87fa19Trac #20093: import sage.all before running external code

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 23, 2016

Reviewer: Daniel Krenn

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 23, 2016

comment:5

LGTM, tests passed on my machine; I'll set it to positive_review as soon as a patchbot confirms this as well.

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 23, 2016

comment:6

Replying to @dkrenn:

I'll set it to positive_review as soon as a patchbot confirms this as well.

Patchbot sees ticket as unsafe. But since my tests were sucessful, I give it a positive review.

@vbraun
Copy link
Member

vbraun commented Feb 24, 2016

Changed branch from u/jdemeyer/ticket/20093 to f87fa19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants