Add pictures to plot3d.py

[sagetrac-jhonrubia6]

Patch to add pictures generated using .. PLOT:: to the plot3d.py file

CC: @egourgoulhon

Component: documentation

Keywords: pictures, plot

Author: Javier Honrubia González

Branch: 2962cd9

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/20109

[sagetrac-jhonrubia6]

Branch: t/20109/add_pictures_to_plot3d_py

[sagetrac-jhonrubia6]

Changed branch from t/20109/add_pictures_to_plot3d_py to none

[sagetrac-jhonrubia6]

Branch: u/jhonrubia6/add_pictures_to_plot3d_py

[sagetrac-jhonrubia6]

New commits:

a46d881

Added pictures to plot3d.py and auxiliar plot() methods in base.pyx and parametric_surface.pyx

[sagetrac-jhonrubia6]

Author: Javier Honrubia Gonzalez

[sagetrac-jhonrubia6]

Commit: a46d881

[sagetrac-jhonrubia6]

Changed keywords from none to pictures, plot

[sagetrac-git]

Changed commit from a46d881 to 230bf0c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

230bf0c

Added some doctest to the plot() methods in parametric_surface.pyx and base.pyx

[dimpase]

comment:8

what is the purpose of these tautological def plot(self): ? To support PLOT:: blocks in docstrings?

[sagetrac-jhonrubia6]

comment:9

Replying to @dimpase:

what is the purpose of these tautological def plot(self): ? To support PLOT:: blocks in docstrings?

It is the way Nathann Cohen implemented the code in sphinx_plot (#17498), it works fine but some objects need a plot method to be invoked in sphinx_plot().

[dimpase]

comment:10

Could you add to docstrings of these two plot() functions something like needed to support PLOT in doctrings ?

Otherwise it's quite baffling to see...

[sagetrac-jhonrubia6]

comment:11

Replying to @dimpase:

Could you add to docstrings of these two plot() functions something like needed to support PLOT in doctrings ?

Otherwise it's quite baffling to see...

sure, it does make sense. I will do it in my next commit

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2962cd9

Added some comments clarifying the need of plot() methods.

[sagetrac-git]

Changed commit from 230bf0c to 2962cd9

[dimpase]

comment:13

Where exactly in the docs should one see these new figures?

I don't get any pictures in reference/plot3d/sage/plot/plot3d/parametric_plot3d.html

[sagetrac-jhonrubia6]

comment:14

Replying to @dimpase:

Where exactly in the docs should one see these new figures?

I don't get any pictures in reference/plot3d/sage/plot/plot3d/parametric_plot3d.html

No, the pictures are in reference/plot3d/sage/plot/plot3d/plot3d.html

[dimpase]

comment:15

Replying to @sagetrac-jhonrubia6:

Replying to @dimpase:

Where exactly in the docs should one see these new figures?

I don't get any pictures in reference/plot3d/sage/plot/plot3d/parametric_plot3d.html

No, the pictures are in reference/plot3d/sage/plot/plot3d/plot3d.html

wow, cool pictures!!!

[sagetrac-jhonrubia6]

Reviewer: Dima Pasechnik

[vbraun]

Changed branch from u/jhonrubia6/add_pictures_to_plot3d_py to 2962cd9

[jdemeyer]

Changed commit from 2962cd9 to none

[jdemeyer]

Changed author from Javier Honrubia Gonzalez to Javier Honrubia González