Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify LinearCode.zero method #20113

Closed
sagetrac-dlucas mannequin opened this issue Feb 25, 2016 · 9 comments
Closed

Simplify LinearCode.zero method #20113

sagetrac-dlucas mannequin opened this issue Feb 25, 2016 · 9 comments
Labels
c: coding theory good first issue p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Feb 25, 2016

Implementation of method zero from AbstractLinearCode can be improved by just returning the zero vector of the ambient space of the code.

Component: coding theory

Author: David Lucas

Branch/Commit: 806642e

Reviewer: Arpit Merchant

Issue created by migration from https://trac.sagemath.org/ticket/20113
@sagetrac-dlucas sagetrac-dlucas mannequin added this to the sage-7.1 milestone Feb 25, 2016
@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 25, 2016

Branch: u/dlucas/zero_of_codes

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 25, 2016

Changed keywords from "beginner" to none

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 25, 2016

Author: David Lucas

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 25, 2016

comment:2

Pushed the fix, it's now open for review.

New commits:

806642eRewrote zero method for codes

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 25, 2016

Commit: 806642e

@arpitdm
Copy link
Mannequin

arpitdm mannequin commented Mar 13, 2016

comment:3

I agree with the changes, the tests pass. I'm giving this a positive review.

@tscrim
Copy link
Collaborator

tscrim commented Mar 13, 2016

comment:4

You will need to put your real name as the reviewer.

@arpitdm
Copy link
Mannequin

arpitdm mannequin commented Mar 13, 2016

Reviewer: Arpit Merchant

@vbraun
Copy link
Member

vbraun commented Mar 20, 2016

Changed branch from u/dlucas/zero_of_codes to 806642e

@vbraun vbraun closed this as completed in 9ee55d0 Mar 20, 2016
@sagetrac-dlucas sagetrac-dlucas mannequin mentioned this issue Jan 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coding theory good first issue p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
2 participants
@vbraun @tscrim