Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some more typos and raise statements #20131

Closed
fchapoton opened this issue Feb 27, 2016 · 10 comments
Closed

some more typos and raise statements #20131

fchapoton opened this issue Feb 27, 2016 · 10 comments

Comments

@fchapoton
Copy link
Contributor

  • a few minor corrections in the doc

  • a few changes of raise syntax to py3 format

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 6dbc62e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20131

@fchapoton fchapoton added this to the sage-7.1 milestone Feb 27, 2016
@fchapoton
Copy link
Contributor Author

Branch: public/20131

@fchapoton
Copy link
Contributor Author

New commits:

aaf9bf8more typoes and raise into python3

@fchapoton
Copy link
Contributor Author

Commit: aaf9bf8

@tscrim
Copy link
Collaborator

tscrim commented Feb 28, 2016

comment:2

Two things:

  • In padic_generic.py, in the doc you changed, could you also put it in code format?
  • For _find_zeros_mod_p, while we are making changes, we should make it the declarative Find.

Also do we want to change the formatting of the error messages? (surprise)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 28, 2016

Changed commit from aaf9bf8 to 6dbc62e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 28, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

6dbc62etrac #20131 some of reviewer's comments

@fchapoton
Copy link
Contributor Author

comment:4

Hello,

I only changed a few of the raise formatting (no capital, not dot). This kind of change makes the ticket less obvious to review. Now let us see if the bots complains.

@tscrim
Copy link
Collaborator

tscrim commented Feb 28, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 28, 2016

comment:5

LGTM (and the bot). Thanks.

@vbraun
Copy link
Member

vbraun commented Feb 29, 2016

Changed branch from public/20131 to 6dbc62e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants