Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use arb_set_str for RBF(string) #20188

Closed
fredrik-johansson opened this issue Mar 10, 2016 · 10 comments
Closed

use arb_set_str for RBF(string) #20188

fredrik-johansson opened this issue Mar 10, 2016 · 10 comments

Comments

@fredrik-johansson
Copy link

With this patch, it becomes possible to round-trip RBF -> str -> RBF. Also, large exponents are supported.

Component: numerical

Keywords: arb

Author: Fredrik Johansson

Branch/Commit: 8af0db5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20188

@fredrik-johansson
Copy link
Author

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2016

Commit: 8af0db5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

8af0db5use arb_set_str to create RealBall from string

@fredrik-johansson
Copy link
Author

Changed keywords from none to arb

@fredrik-johansson
Copy link
Author

comment:3

By the way, the __init__ method is not included on the documentation page. Something that should be changed?

@fredrik-johansson

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Mar 11, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Mar 11, 2016

comment:4

Replying to @fredrik-johansson:

By the way, the __init__ method is not included on the documentation page. Something that should be changed?

I believe what you want is

.. automethod:: __init__

See the "private functions" subsection of http://doc.sagemath.org/html/en/developer/coding_basics.html#documentation-strings.

Personally I try to put such documentation at the class level.

Branch LGTM, so if you don't want to fiddle with the documentation, you can set this to a positive review (once you set the author name).

@fredrik-johansson
Copy link
Author

Author: Fredrik Johansson

@vbraun
Copy link
Member

vbraun commented Mar 22, 2016

Changed branch from u/fredrik.johansson/use_arb_set_str_for_rbf_string_ to 8af0db5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants