Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use repr for "unable to convert" error messages #20212

Closed
jdemeyer opened this issue Mar 15, 2016 · 7 comments
Closed

Use repr for "unable to convert" error messages #20212

jdemeyer opened this issue Mar 15, 2016 · 7 comments
Labels
p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@jdemeyer
Copy link

It is good to differentiate between

sage: ZZ("x")
TypeError: unable to convert 'x' to an integer

and

sage: ZZ(x)
TypeError: unable to convert x to an integer

For this reason, consistently use repr() to format all such exceptions (similar to the ZZ example above).

Component: misc

Author: Jeroen Demeyer

Branch/Commit: a68bf50

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20212
@jdemeyer jdemeyer added this to the sage-7.1 milestone Mar 15, 2016
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Use repr() for "unable to convert" error messages Use repr for "unable to convert" error messages Mar 15, 2016
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/20212

@jdemeyer
Copy link
Author

New commits:

a68bf50Use repr for "unable to convert" error messages

@jdemeyer
Copy link
Author

Commit: a68bf50

@tscrim
Copy link
Collaborator

tscrim commented Mar 15, 2016

comment:4

LGTM (I don't particular care for the verbosity for the induced crystals error message, but I understand that it is there for consistency/explanation).

@tscrim
Copy link
Collaborator

tscrim commented Mar 15, 2016

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Mar 22, 2016

Changed branch from u/jdemeyer/ticket/20212 to a68bf50

@vbraun vbraun closed this as completed in 307f98d Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer