fix flintxx development

[rwst]

Current flint-2.5.2 is from last year and lacks a recent fix from git master addressing compile errors of flintxx headers. This ticket patches Sage's flint to enable Pynac development with flintxx, the C++ API of flint.

flintlib/flint@c0768dc

Component: packages: standard

Author: Ralf Stephan

Branch/Commit: 45ebadb

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/20281

[rwst]

Branch: u/rws/fix_flintxx_development

[rwst]

New commits:

350d137

20281: fix flintxx development

[rwst]

Commit: 350d137

[rwst]

Author: Ralf Stephan

[jdemeyer]

comment:3

pynac doesn't use flint.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

45ebadb

20281: revert Pynac dependency, add it later

[sagetrac-git]

Changed commit from 350d137 to 45ebadb

[jdemeyer]

Reviewer: Jeroen Demeyer

[rwst]

comment:7

Thanks.

[kiwifb]

comment:8

I personally don't think the fix you submitted upstream is any good. You are probably configuring with -I${some_prefix}/flint/flintxx when you should use -I${some_prefix}/flint -I${some_prefix}/flint/flintxx. In fact it would be better, I think, to only have ${some_prefx}/flint and have the flintxx headers prefixed with flintxx.

[kiwifb]

comment:9

Possibly, depending on your includes it should have been #include "flint/flint.h" rather than #include "../flint.h". That fells more correct to me.

[rwst]

comment:10

It is a complete mystery to me how you get the idea that I submitted anything upstream. I merely reported the issue at flintlib/flint#217. Consequently your remarks should be added there.

[kiwifb]

comment:11

Right I saw "reported by Ralph Stephan and fixed by ..." and I have conflated things a little bit. I guess I thought you worked together. But right it is just that I don't think it is a good solution in my opinion.

[vbraun]

Changed branch from u/rws/fix_flintxx_development to 45ebadb