Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8 cleanup in game_theory #20289

Closed
fchapoton opened this issue Mar 25, 2016 · 9 comments
Closed

pep8 cleanup in game_theory #20289

fchapoton opened this issue Mar 25, 2016 · 9 comments

Comments

@fchapoton
Copy link
Contributor

just to correct a typo and a few pep8 details in game_theory

Component: game theory

Author: Frédéric Chapoton

Branch/Commit: 6a5df50

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20289

@fchapoton fchapoton added this to the sage-7.2 milestone Mar 25, 2016
@fchapoton
Copy link
Contributor Author

Commit: e34a81f

@fchapoton
Copy link
Contributor Author

Branch: public/20289

@fchapoton
Copy link
Contributor Author

New commits:

e34a81ffull pep8 in game_theory

@tscrim
Copy link
Collaborator

tscrim commented Mar 25, 2016

comment:2

It looks good overall except for this change:

-    g = AntiCoordinationGame(A=v/2-c, a=v/2-c, B=0, b=v, C=v, c=0, D=v/2, d=v/2)
+    g = AntiCoordinationGame(A=v / 2 - c, a=v / 2 - c, B=0, b=v,
+                             C=v, c=0, D=v / 2, d=v / 2)

I think it makes it less readable and is one of those cases where we should not follow PEP8 to the letter.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 25, 2016

Changed commit from e34a81f to 6a5df50

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

83cef7cMerge branch 'public/20289' into 7.2.b0
6a5df50trac #20289 reviewer's comment

@tscrim
Copy link
Collaborator

tscrim commented Mar 25, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Mar 25, 2016

comment:4

Thank you.

@vbraun
Copy link
Member

vbraun commented Mar 27, 2016

Changed branch from public/20289 to 6a5df50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants