Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_digraph method to RecursivelyEnumeratedSet #20341

Closed
seblabbe opened this issue Apr 1, 2016 · 10 comments
Closed

Add to_digraph method to RecursivelyEnumeratedSet #20341

seblabbe opened this issue Apr 1, 2016 · 10 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-7.2

Comments

@seblabbe
Copy link
Contributor

seblabbe commented Apr 1, 2016 

sage: f = lambda a: [a+1, a+I] 
sage: C = RecursivelyEnumeratedSet([0], f, structure='graded') 
sage: C.to_digraph(max_depth=4)  
Looped multi-digraph on 21 vertices

Component: combinatorics

Author: Sébastien Labbé

Branch/Commit: c9a8067

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20341
@seblabbe seblabbe added this to the sage-7.2 milestone Apr 1, 2016
@seblabbe
Copy link
Contributor Author

seblabbe commented Apr 1, 2016

Commit: 2c36bbb

@seblabbe
Copy link
Contributor Author

seblabbe commented Apr 1, 2016

New commits:

2c36bbb#20341: adding to_digraph to recursively_enumerated_set

@seblabbe
Copy link
Contributor Author

seblabbe commented Apr 1, 2016

Branch: u/slabbe/20341

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2016

Changed commit from 2c36bbb to 86fe5ce

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

86fe5ce20341: adding to_digraph to recursively_enumerated_set

@tscrim
Copy link
Collaborator

tscrim commented Apr 3, 2016

comment:3

A few small things:

  • Make Default -> default and remove the period from the first input?
  • De-indent the output.
  • Change .. NOTE:: to .. WARNING::.

LGTM otherwise. So once you make those changes, you can set a positive review on my behalf.

@tscrim
Copy link
Collaborator

tscrim commented Apr 3, 2016

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2016

Changed commit from 86fe5ce to c9a8067

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

c9a806720341: fixing reviewer comments

@vbraun
Copy link
Member

vbraun commented Apr 4, 2016

Changed branch from u/slabbe/20341 to c9a8067

@vbraun vbraun closed this as completed in 36b5c28 Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @seblabbe