Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize PARI constants in PariInstance.__init__ #20352

Closed
jdemeyer opened this issue Apr 3, 2016 · 10 comments
Closed

Initialize PARI constants in PariInstance.__init__ #20352

jdemeyer opened this issue Apr 3, 2016 · 10 comments
Labels
c: interfaces p: major / 3 t: enhancement
Milestone
sage-7.2

Comments

@jdemeyer
Copy link

jdemeyer commented Apr 3, 2016

CC: @defeo

Component: interfaces

Keywords: days77

Author: Jeroen Demeyer

Branch/Commit: 9d2865b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20352
@jdemeyer jdemeyer added this to the sage-7.2 milestone Apr 3, 2016
@jdemeyer
Copy link
Author

jdemeyer commented Apr 3, 2016

Branch: u/jdemeyer/ticket/20352

@jdemeyer
Copy link
Author

jdemeyer commented Apr 3, 2016

New commits:

e33844fInitialize PARI constants in PariInstance.__init__

@jdemeyer
Copy link
Author

jdemeyer commented Apr 3, 2016

Commit: e33844f

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2016

comment:3

Could you clarify the comment about PARI_* being global variables? As least in this code they are class level variables. I'm guessing they are global variables for PARI?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2016

Changed commit from e33844f to 9d2865b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

9d2865bFix comment

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2016

comment:5

Thanks.

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2016

Reviewer: Travis Scrimshaw

@slel
Copy link
Member

slel commented Apr 4, 2016

Changed keywords from none to days77

@vbraun
Copy link
Member

vbraun commented Apr 5, 2016

Changed branch from u/jdemeyer/ticket/20352 to 9d2865b

@vbraun vbraun closed this as completed in 4d2396f Apr 5, 2016
@jdemeyer jdemeyer mentioned this issue Apr 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.2
Development

No branches or pull requests
4 participants
@vbraun @tscrim @slel @jdemeyer