Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sphinxify to Sage #20353

Closed
jdemeyer opened this issue Apr 3, 2016 · 10 comments
Closed

Move sphinxify to Sage #20353

jdemeyer opened this issue Apr 3, 2016 · 10 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Apr 3, 2016

The file src/sage/misc/sagedoc.py imports sphinxify from sagenb. This is bad, since sagenb should not be a dependency for the Sage documentation.

CC: @hivert

Component: documentation

Keywords: days77

Author: Jeroen Demeyer

Branch/Commit: 71a7cb6

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/20353

@jdemeyer jdemeyer added this to the sage-7.2 milestone Apr 3, 2016
@jdemeyer
Copy link
Author

jdemeyer commented Apr 3, 2016

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

jdemeyer commented Apr 4, 2016

@jdemeyer
Copy link
Author

jdemeyer commented Apr 4, 2016

New commits:

4b206a2Move sphinxify to Sage

@jdemeyer
Copy link
Author

jdemeyer commented Apr 4, 2016

Commit: 4b206a2

@jdemeyer jdemeyer changed the title Uncouple documentation builder from sagenb Move sphinxify to Sage Apr 4, 2016
@slel
Copy link
Member

slel commented Apr 4, 2016

Changed keywords from none to days77

@jhpalmieri
Copy link
Member

comment:5

I think this could use one more change:

diff --git a/src/doc/en/reference/misc/index.rst b/src/doc/en/reference/misc/index.rst
index 3fcd5b0..10a0a1d 100644
--- a/src/doc/en/reference/misc/index.rst
+++ b/src/doc/en/reference/misc/index.rst
@@ -226,6 +226,7 @@ Interactive Sage Sessions
    sage/misc/viewer
    sage/misc/pager
    sage/misc/sagedoc
+   sage/misc/sphinxify
 
 Distribution
 ~~~~~~~~~~~~

Then I think it's ready to go.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2016

Changed commit from 4b206a2 to 71a7cb6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

71a7cb6Add sphinxify to the documentation

@jdemeyer
Copy link
Author

jdemeyer commented Apr 7, 2016

Reviewer: John Palmieri

@vbraun
Copy link
Member

vbraun commented Apr 8, 2016

Changed branch from u/jdemeyer/uncouple_documentation_builder_from_sagenb to 71a7cb6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants