Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize use of is_package_installed at runtime #20377

Closed
kiwifb opened this issue Apr 7, 2016 · 14 comments
Closed

Minimize use of is_package_installed at runtime #20377

kiwifb opened this issue Apr 7, 2016 · 14 comments

Comments

@kiwifb
Copy link
Member

kiwifb commented Apr 7, 2016

This is helpful for sage-on-distributions. Typically sage-on-distribution do not want, or need, to call sage's internal packaging system.

I raised this as part of Sage days 77.

Related tickets:

CC: @slel

Component: packages: optional

Keywords: sagedays 77

Author: François Bissey

Branch/Commit: u/fbissey/is_pkg_installed @ aba00ce

Issue created by migration from https://trac.sagemath.org/ticket/20377

@kiwifb kiwifb added this to the sage-7.2 milestone Apr 7, 2016
@mezzarobba
Copy link
Member

comment:2

Your branch points to the latest beta, did you forget to push or something?

@kiwifb
Copy link
Member Author

kiwifb commented Apr 7, 2016

comment:4

I forgot to commit :(

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2016

Changed commit from 7ffcdd1 to a8e2087

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

a8e2087first draft of minimizing is_package_installed

@videlec
Copy link
Contributor

videlec commented Apr 7, 2016

comment:7

You forget a colon

  File "/home/worker/sage-patchbot/local/lib/python2.7/site-packages/sage/groups/generic.py", line 1407
    if not os.path.isfile(os.path.join(SAGE_LOCAL, "gap", "latest", "small", "readsml.g"))

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2016

Changed commit from a8e2087 to d7d8483

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

d7d8483Add forgotten ":"

@kiwifb
Copy link
Member Author

kiwifb commented Apr 7, 2016

comment:9

If that's all I forgot that's not a bad score. This particular one was different in sage-on-gentoo because I don't ship this database separately from gap like it is done in sage so it doesn't need testing.
I'll still need to patch that one one way or another because the path will be different on gentoo. Alternative proposal welcome.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2016

Changed commit from d7d8483 to aba00ce

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 7, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

aba00ceMerge branch 'develop' into is_pkg_installed

@saraedum
Copy link
Member

saraedum commented Apr 7, 2016

comment:11

It seems we are working on the same issue ;)
#20382 does essentially the same, maybe you want to have a look.

It seems to me that my approach is slightly more generic but I am open for discussion.

@slel

This comment has been minimized.

@slel slel changed the title minimizing the use of is_package_install at runtime Minimize use of is_package_installed at runtime Aug 29, 2016
@jdemeyer
Copy link

comment:13

Is this still relevant or should it be closed in the light of #20382?

@kiwifb
Copy link
Member Author

kiwifb commented Mar 19, 2018

comment:14

Replying to @jdemeyer:

Is this still relevant or should it be closed in the light of #20382?

I think I should have marked this one duplicate months ago. There is nothing in here that #20382 doesn't do better.

@kiwifb kiwifb removed this from the sage-7.2 milestone Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants