Do not hardcode singular include path

[jdemeyer]

Get rid of include_dirs = singular_incs in setup.py to enable easier packaging for Nix/Guix/hashdist-style distros.

CC: @sagetrac-aenge @saraedum

Component: build

Keywords: days77

Author: Jeroen Demeyer

Branch/Commit: e09a255

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/20386

[jdemeyer]

Changed keywords from none to days77

[jdemeyer]

Branch: u/jdemeyer/do_not_hardcode_singular_include_path

[jdemeyer]

New commits:

685a35b

Include all Singular includes in $SAGE_LOCAL/include/singular

[jdemeyer]

Commit: 685a35b

[saraedum]

Reviewer: Julian Rüth

[vbraun]

comment:7

Doesn't work, see patchbot

[jdemeyer]

comment:8

Not sure why it worked for me... testing again after make distclean; make

[sagetrac-git]

Changed commit from 685a35b to 0aae37d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0aae37d

Patch Singular to use the correct include directories

[sagetrac-git]

Changed commit from 0aae37d to e09a255

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e09a255

Add a link in the patch to the ticket

[jdemeyer]

comment:11

Apparently, some Singular Makefile actually rewrites the include path from the correct to the wrong path. I added a Singular patch to remove one sed command fixing the issue. This now works even after make distclean.

[saraedum]

comment:13

Thanks for figuring this out :)
To bad that we have to patch Singular but their build is just broken it seems.

[vbraun]

Changed branch from u/jdemeyer/do_not_hardcode_singular_include_path to e09a255