Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type recognition of Coxeter matrix #20419

Closed
tscrim opened this issue Apr 11, 2016 · 10 comments
Closed

Fix type recognition of Coxeter matrix #20419

tscrim opened this issue Apr 11, 2016 · 10 comments
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-7.2

Comments

@tscrim
Copy link
Collaborator

tscrim commented Apr 11, 2016

We have type A -> B -> G:

sage: M = CoxeterMatrix(['A',2])
sage: CoxeterMatrix(matrix(M)).coxeter_type()
Coxeter type of ['B', 2]
sage: M = CoxeterMatrix(['B',2])
sage: CoxeterMatrix(matrix(M)).coxeter_type()
Coxeter type of ['G', 2]

CC: @sagetrac-sage-combinat @nthiery @fchapoton @darijgr @stumpc5

Component: combinatorics

Author: Travis Scrimshaw

Branch: 56e5127

Reviewer: Darij Grinberg

Issue created by migration from https://trac.sagemath.org/ticket/20419
@tscrim tscrim added this to the sage-7.2 milestone Apr 11, 2016
@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

Commit: 56e5127

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

New commits:

56e5127Fixing rank 2 type recognition.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

Branch: public/combinat/fix_type_recognitin_coxeter_matrix-20419

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

Author: Travis Scrimshaw

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

comment:2

This occurred only in rank 2, and we were just not checking the entries correctly.

@darijgr
Copy link
Contributor

darijgr commented Apr 11, 2016

comment:3

Congrats, this is the first ticket I've been able to review from a tablet.

If all tests pass, please set to positive review!

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

comment:4

Thanks.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

Reviewer: Darij Grinberg

@vbraun
Copy link
Member

vbraun commented Apr 12, 2016

Changed branch from public/combinat/fix_type_recognitin_coxeter_matrix-20419 to 56e5127

@vbraun vbraun closed this as completed in b92285a Apr 12, 2016
@fchapoton
Copy link
Contributor

Changed commit from 56e5127 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-7.2
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @darijgr