Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversions matrix -> AffineGroup #20422

Closed
jdemeyer opened this issue Apr 11, 2016 · 8 comments
Closed

Fix conversions matrix -> AffineGroup #20422

jdemeyer opened this issue Apr 11, 2016 · 8 comments

Comments

@jdemeyer
Copy link

Conversion from a matrix representing an affine transformation to an affine group element only works in dimension 2 (due to a hard-coded 2 in __init__). Conversion from a matrix group element to an affine group element also does not work.

CC: @vbraun

Component: group theory

Author: Jeroen Demeyer

Branch/Commit: d9f8bde

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/20422

@jdemeyer jdemeyer added this to the sage-7.2 milestone Apr 11, 2016
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/20422

@jdemeyer
Copy link
Author

Commit: d9f8bde

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

New commits:

d9f8bdeFix conversions matrix -> AffineGroup

@fchapoton
Copy link
Contributor

comment:4

ok, looks good to me

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@jdemeyer
Copy link
Author

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Apr 15, 2016

Changed branch from u/jdemeyer/ticket/20422 to d9f8bde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants