Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow *generic* matrix eigenspaces for inexact fields (very easy to implement) #2050

Closed
williamstein opened this issue Feb 5, 2008 · 6 comments

Comments

@williamstein
Copy link
Contributor

Instead of lying the following code should just raise a NotImplementedError. Basically use the is_exact() method on rings to determine if the ring is not exact, and if so, raise an error on eigenspaces computation. Some generic algorithms suck for inexact rings. One thing, the error message for RR and CC could suggest using RDF or CDF... and maybe when prec <= 53, the code could use RDF or CDF (?).

sage: R=RealField(30)
sage: M=matrix(R,2,[2,1,1,1])
sage: M.eigenspaces()

[
(2.6180340, [

]),
(0.38196601, [

])
]

CC: @ncalexan

Component: linear algebra

Issue created by migration from https://trac.sagemath.org/ticket/2050

@williamstein williamstein added this to the sage-2.10.3 milestone Feb 5, 2008
@williamstein williamstein self-assigned this Feb 5, 2008
@williamstein
Copy link
Contributor Author

comment:1

See #1706 for a related ticket.

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Feb 17, 2008

Attachment: 2050-ncalexan-eigenspaces-1.patch.gz

@ncalexan ncalexan mannequin added the s: needs review label Feb 17, 2008
@mwhansen
Copy link
Contributor

comment:4

I get the following against 2.10.3.alpha0:

cd "/home/mhansen/sage-2.10.3.alpha0/devel/sage" && hg status
cd "/home/mhansen/sage-2.10.3.alpha0/devel/sage" && hg status
cd "/home/mhansen/sage-2.10.3.alpha0/devel/sage" && hg import   "/home/mhansen/.sage/temp/sage/15288/tmp_0.patch"
applying /home/mhansen/.sage/temp/sage/15288/tmp_0.patch
patching file sage/matrix/matrix2.pyx
Hunk #4 succeeded at 2130 with fuzz 2 (offset 0 lines).
Hunk #5 FAILED at 2146
Hunk #6 FAILED at 2163
2 out of 7 hunks FAILED -- saving rejects to file sage/matrix/matrix2.pyx.rej
abort: patch failed to apply

@mwhansen
Copy link
Contributor

Attachment: 2250.patch.gz

Attachment: 2050.patch.gz

@mwhansen
Copy link
Contributor

comment:5

I've made a patch 2050 which applies cleanly after #2299 . All tests pass so things look good to me.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 28, 2008

comment:6

Merged 2050.patch in Sage 2.10.3.rc0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Feb 28, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants