Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with cyclotomic fields embeddings and coercions #20513

Closed
videlec opened this issue Apr 28, 2016 · 14 comments
Closed

bug with cyclotomic fields embeddings and coercions #20513

videlec opened this issue Apr 28, 2016 · 14 comments

Comments

@videlec
Copy link
Contributor

videlec commented Apr 28, 2016

sage: K60.<zeta60> = CyclotomicField(60)
sage: K30.<zeta30> = CyclotomicField(30, embedding=zeta60**2)
sage: K15.<zeta15> = CyclotomicField(15, embedding=zeta30**2)
sage: K5.<zeta5> = CyclotomicField(5, embedding=zeta15**3)
sage: zeta5 * zeta60
# BOOM #

see: https://groups.google.com/forum/#!topic/sage-support/J4rLkHUNU1E

CC: @JohnCremona

Component: number fields

Author: Vincent Delecroix

Branch/Commit: 1b5051f

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/20513

@videlec videlec added this to the sage-7.2 milestone Apr 28, 2016
@videlec
Copy link
Contributor Author

videlec commented Apr 28, 2016

New commits:

8d8602fTrac 20400: conversion rational in NF -> QQbar
c96139aTrac 20513: fix cyclotomic field embeddings

@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented Apr 28, 2016

Branch: u/vdelecroix/20513

@videlec
Copy link
Contributor Author

videlec commented Apr 28, 2016

Commit: c96139a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 28, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

7ccc962Trac 20513: doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 28, 2016

Changed commit from c96139a to 7ccc962

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 28, 2016

Changed commit from 7ccc962 to 1b5051f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 28, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6992729Trac 20513: fix cyclotomic field embeddings
1b5051fTrac 20513: doctest

@JohnCremona
Copy link
Member

comment:4

The code looks good. I am building the branch to test now.

@kedlaya
Copy link
Sponsor Contributor

kedlaya commented May 19, 2016

comment:5

Maybe add the example from #20261 as another doctest?

@videlec
Copy link
Contributor Author

videlec commented May 19, 2016

comment:6

#20261 is not fixed by this ticket.

@vbraun
Copy link
Member

vbraun commented Jul 9, 2016

Reviewer: Volker Braun

@videlec
Copy link
Contributor Author

videlec commented Jul 9, 2016

comment:8

Thanks Volker!

@vbraun
Copy link
Member

vbraun commented Jul 10, 2016

Changed branch from u/vdelecroix/20513 to 1b5051f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants