Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 print in calculus and coding #20527

Closed
fchapoton opened this issue May 1, 2016 · 17 comments
Closed

py3 print in calculus and coding #20527

fchapoton opened this issue May 1, 2016 · 17 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.3

Comments

@fchapoton
Copy link
Contributor

another small step towards python3 print

CC: @videlec @tscrim @jdemeyer @embray

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 0024111

Reviewer: Jeroen Demeyer, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20527
@fchapoton fchapoton added this to the sage-7.2 milestone May 1, 2016
@fchapoton
Copy link
Contributor Author

New commits:

058e63dpy3 print in coding and calculus

@fchapoton
Copy link
Contributor Author

Branch: public/20527

@fchapoton
Copy link
Contributor Author

Commit: 058e63d

@jdemeyer
Copy link

jdemeyer commented May 2, 2016

comment:3

I would much rather prefer to just remove the commented-out # print calls. Reviewing commented-out code seems pointless.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 2, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

5f985a1trac 20257 removal of many commented prints

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 2, 2016

Changed commit from 058e63d to 5f985a1

@fchapoton
Copy link
Contributor Author

comment:5

yes, indeed. Done.

@jdemeyer
Copy link

jdemeyer commented May 2, 2016

comment:6

Same for print calls in if False: blocks...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 2, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

0024111trac #20527 removing code inside "if False"

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 2, 2016

Changed commit from 5f985a1 to 0024111

@fchapoton
Copy link
Contributor Author

comment:8

hmm, I removed completely the content of the if False blocks, but maybe this is too intrusive ?

@fchapoton
Copy link
Contributor Author

comment:9

ping ?

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer jdemeyer modified the milestones: sage-7.2, sage-7.3 May 13, 2016
@fchapoton
Copy link
Contributor Author

comment:11

re-ping ?

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2016

Changed reviewer from Jeroen Demeyer to Jeroen Demeyer, Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2016

comment:12

I think it is okay.

@vbraun
Copy link
Member

vbraun commented May 18, 2016

Changed branch from public/20527 to 0024111

@vbraun vbraun closed this as completed in c27f7d9 May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.3
Development

No branches or pull requests
4 participants
@vbraun @tscrim @jdemeyer @fchapoton