Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 print in matrix folder #20541

Closed
fchapoton opened this issue May 3, 2016 · 11 comments
Closed

py3 print in matrix folder #20541

fchapoton opened this issue May 3, 2016 · 11 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.2

Comments

@fchapoton
Copy link
Contributor

another step towards python3 print

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 7c12326

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/20541
@fchapoton fchapoton added this to the sage-7.2 milestone May 3, 2016
@fchapoton
Copy link
Contributor Author

Branch: public/20541

@fchapoton
Copy link
Contributor Author

New commits:

fd35ef0python3 print in matrices folder

@fchapoton
Copy link
Contributor Author

Commit: fd35ef0

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 3, 2016

comment:2

Seems to be OK. I'll compile and check before setting positive review.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 3, 2016

Reviewer: Jori Mäntysalo

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 3, 2016

comment:3

Not OK: In matrix_modn_dense_template.pxi first TEST block has the line

print('{} x {} = {}'.format(v, m, v * m)

i.e. missing a closing parenthesis.

@jm58660 jm58660 mannequin added s: needs work and removed s: needs review labels May 3, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

7c12326python 3 print for matrices, detail

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2016

Changed commit from fd35ef0 to 7c12326

@fchapoton
Copy link
Contributor Author

comment:5

done

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 3, 2016

comment:6

Good now.

@vbraun
Copy link
Member

vbraun commented May 5, 2016

Changed branch from public/20541 to 7c12326

@vbraun vbraun closed this as completed in 10f7157 May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.2
Development

No branches or pull requests
2 participants
@vbraun @fchapoton