py3 print in libs folder

[fchapoton]

a small step towards python3 print

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 6836c5c

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/20556

[fchapoton]

Commit: 7c59df3

[fchapoton]

Branch: public/20556

[fchapoton]

New commits:

7c59df3

python3 print in libs

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

comment:2

positive_review if the bot gives the green light.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5f3ec6e

oops, forgot one print to python3

[sagetrac-git]

Changed commit from 7c59df3 to 5f3ec6e

[sagetrac-git]

Changed commit from 5f3ec6e to 468c1dd

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

468c1dd

python3 print in libs, details

[jdemeyer]

comment:5

Why the last commit? Isn't mpmath supposed to be system-independent?

[fchapoton]

comment:7

you mean the abs tol ? I guess I removed a print that was truncating the numerical value.
Should I instead

• put back a print ?
• replace by the correct numerical value ?

[jdemeyer]

comment:8

replace by the correct numerical value ?

Of course.

[jdemeyer]

comment:9

The # tol is stuff is meant for system-dependent doctests. Not for "I am too lazy to write all the digits". Especially for things where it is a feature that they are system-independent.

[sagetrac-git]

Changed commit from 468c1dd to 6836c5c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6836c5c

python3 print in libs, replace by correct numerical value instead of abs tol

[fchapoton]

comment:11

done

[jdemeyer]

comment:12

Let's see what the patchbot says...

[jdemeyer]

comment:13

Won't the changes to src/sage/libs/readline.pyx break the doctest since you replaced print a,b by print(a,b).

[fchapoton]

comment:14

no, because this is in the code, not in the doc, and we have the future import

[jdemeyer]

comment:15

I see... so there is really a big difference between changes in the code and in the doctests.

If the bot gives the green light, you can set this to positive_review.

[fchapoton]

comment:16

ok, bot has turned green.

[vbraun]

Changed branch from public/20556 to 6836c5c