Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3 print in combinat/root_system folder #20573

Closed
fchapoton opened this issue May 9, 2016 · 11 comments
Closed

py3 print in combinat/root_system folder #20573

fchapoton opened this issue May 9, 2016 · 11 comments

Comments

@fchapoton
Copy link
Contributor

another step towards python3 print

CC: @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 1d7af27

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20573

@fchapoton fchapoton added this to the sage-7.3 milestone May 9, 2016
@fchapoton
Copy link
Contributor Author

Commit: e0dd5a0

@fchapoton
Copy link
Contributor Author

New commits:

e0dd5a0python3 print in combinat/root_system folder

@fchapoton
Copy link
Contributor Author

Branch: public/20573

@tscrim
Copy link
Collaborator

tscrim commented May 9, 2016

Reviewer: Travis Scrimshaw

@fchapoton
Copy link
Contributor Author

comment:3

Thanks a lot Travis.

@vbraun
Copy link
Member

vbraun commented May 19, 2016

comment:4

See also patchbot

sage -t --long src/sage/combinat/root_system/root_lattice_realizations.py
**********************************************************************
File "src/sage/combinat/root_system/root_lattice_realizations.py", line 1673, in sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.tau_epsilon_operator_on_almost_positive_roots
Failed example:
    for root in L.almost_positive_roots():
         print('tau({:<41}) ='.format(root), tau(root))
Expected:
    tau(-alpha[1]                                ) = alpha[1]
    tau(alpha[1]                                 ) = -alpha[1]
    tau(alpha[1] + alpha[2]                      ) = alpha[2] + alpha[3]
    tau(alpha[1] + alpha[2] + alpha[3]           ) = alpha[2]
    tau(alpha[1] + alpha[2] + alpha[3] + alpha[4]) = alpha[2] + alpha[3] + alpha[4]
    tau(-alpha[2]                                ) = -alpha[2]
    tau(alpha[2]                                 ) = alpha[1] + alpha[2] + alpha[3]
    tau(alpha[2] + alpha[3]                      ) = alpha[1] + alpha[2]
    tau(alpha[2] + alpha[3] + alpha[4]           ) = alpha[1] + alpha[2] + alpha[3] + alpha[4]
    tau(-alpha[3]                                ) = alpha[3]
    tau(alpha[3]                                 ) = -alpha[3]
    tau(alpha[3] + alpha[4]                      ) = alpha[4]
    tau(-alpha[4]                                ) = -alpha[4]
    tau(alpha[4]                                 ) = alpha[3] + alpha[4]
Got:
    ('tau(-alpha[1]                                ) =', alpha[1])
    ('tau(alpha[1]                                 ) =', -alpha[1])
    ('tau(alpha[1] + alpha[2]                      ) =', alpha[2] + alpha[3])
    ('tau(alpha[1] + alpha[2] + alpha[3]           ) =', alpha[2])
    ('tau(alpha[1] + alpha[2] + alpha[3] + alpha[4]) =', alpha[2] + alpha[3] + alpha[4])
    ('tau(-alpha[2]                                ) =', -alpha[2])
    ('tau(alpha[2]                                 ) =', alpha[1] + alpha[2] + alpha[3])
    ('tau(alpha[2] + alpha[3]                      ) =', alpha[1] + alpha[2])
    ('tau(alpha[2] + alpha[3] + alpha[4]           ) =', alpha[1] + alpha[2] + alpha[3] + alpha[4])
    ('tau(-alpha[3]                                ) =', alpha[3])
    ('tau(alpha[3]                                 ) =', -alpha[3])
    ('tau(alpha[3] + alpha[4]                      ) =', alpha[4])
    ('tau(-alpha[4]                                ) =', -alpha[4])
    ('tau(alpha[4]                                 ) =', alpha[3] + alpha[4])
**********************************************************************
File "src/sage/combinat/root_system/root_lattice_realizations.py", line 1694, in sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.tau_epsilon_operator_on_almost_positive_roots
Failed example:
    for root in L.almost_positive_roots():
        print('tau({:<41}) ='.format(root), tau(root))
Expected:
    tau((-1, 1, 0)                               ) = (1, -1, 0)
    tau((1, 0, 0)                                ) = (0, 1, 0)
    tau((1, -1, 0)                               ) = (-1, 1, 0)
    tau((1, 1, 0)                                ) = (1, 1, 0)
    tau((1, 0, -1)                               ) = (0, 1, 1)
    tau((1, 0, 1)                                ) = (0, 1, -1)
    tau((0, -1, 1)                               ) = (0, -1, 1)
    tau((0, 1, 0)                                ) = (1, 0, 0)
    tau((0, 1, -1)                               ) = (1, 0, 1)
    tau((0, 1, 1)                                ) = (1, 0, -1)
    tau((0, 0, -1)                               ) = (0, 0, 1)
    tau((0, 0, 1)                                ) = (0, 0, -1)
Got:
    ('tau((-1, 1, 0)                               ) =', (1, -1, 0))
    ('tau((1, 0, 0)                                ) =', (0, 1, 0))
    ('tau((1, -1, 0)                               ) =', (-1, 1, 0))
    ('tau((1, 1, 0)                                ) =', (1, 1, 0))
    ('tau((1, 0, -1)                               ) =', (0, 1, 1))
    ('tau((1, 0, 1)                                ) =', (0, 1, -1))
    ('tau((0, -1, 1)                               ) =', (0, -1, 1))
    ('tau((0, 1, 0)                                ) =', (1, 0, 0))
    ('tau((0, 1, -1)                               ) =', (1, 0, 1))
    ('tau((0, 1, 1)                                ) =', (1, 0, -1))
    ('tau((0, 0, -1)                               ) =', (0, 0, 1))
    ('tau((0, 0, 1)                                ) =', (0, 0, -1))
**********************************************************************
1 item had failures:
   2 of  10 in sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.tau_epsilon_operator_on_almost_positive_roots
    [607 tests, 2 failures, 46.05 s]

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 19, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

12fa7beMerge branch 'public/20573' into 7.2
1d7af27trac 20573 python3 print in combinat/root_system, details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 19, 2016

Changed commit from e0dd5a0 to 1d7af27

@fchapoton
Copy link
Contributor Author

comment:6

corrected, sorry

@fchapoton
Copy link
Contributor Author

comment:7

ok, the bot is happy (except for unrelated 4 tests, see #20529)

I allow myself to set this back to positive

@vbraun
Copy link
Member

vbraun commented May 21, 2016

Changed branch from public/20573 to 1d7af27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants