Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make __doc__ a descriptor instead of using _sage_doc_() #20580

Closed
jdemeyer opened this issue May 9, 2016 · 4 comments
Closed

Make __doc__ a descriptor instead of using _sage_doc_() #20580

jdemeyer opened this issue May 9, 2016 · 4 comments
Labels
c: documentation r: duplicate t: enhancement

Comments

@jdemeyer
Copy link

jdemeyer commented May 9, 2016

Instead of supporting a custom _sage_doc_() method, we should just use standard Python tricks to change __doc__.

This actually breaks in Cython due to some Cython bug(?) with decorators. While trying to fix that bug, I broke @staticmethod because of an unrelated bug http://trac.cython.org/ticket/880

Component: documentation

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/20580
@jdemeyer jdemeyer added this to the sage-7.3 milestone May 9, 2016
@jdemeyer jdemeyer changed the title Make __doc__ a descriptor instead of _sage_doc_ Make __doc__ a descriptor instead of using _sage_doc_() May 9, 2016
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link
Author

comment:3

Duplicate of #22611

@jdemeyer
Copy link
Author

Changed author from Jeroen Demeyer to none

@jdemeyer jdemeyer removed this from the sage-7.3 milestone Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation r: duplicate t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdemeyer