Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NTL to version 9.8.1 #20590

Closed
jpflori opened this issue May 11, 2016 · 27 comments
Closed

Update NTL to version 9.8.1 #20590

jpflori opened this issue May 11, 2016 · 27 comments

Comments

@jpflori
Copy link

jpflori commented May 11, 2016

Lots of speed, threading, and other improvements.
Upstream tarball (not to be used directly):

CC: @jdemeyer @kiwifb

Component: packages: standard

Author: Jean-Pierre Flori, François Bissey

Branch/Commit: fde3485

Reviewer: François Bissey, Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/20590

@jpflori jpflori added this to the sage-7.3 milestone May 11, 2016
@jpflori

This comment has been minimized.

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

comment:2

Looks like I missed the announcement for 9.8.1 I am still at 9.8.0. Unfortunately we cannot take advantage of the threading until a number of things are resolved. Threading requires C++11 and a number of packages are behind the curve.
We need #17635 so givaro, fflas-ffpack and linbox will be using C++11, I have a PR with eclib that John is ready to merge and then a new release needs to be cut. Finally singular and flint will need to be hacked. I have a proof of concept for those in sage-on-gentoo.

Do you want to go ahead with the upgrade and do the threading later?

@jpflori
Copy link
Author

jpflori commented May 11, 2016

comment:3

Yes, let's just upgrade and go with threading later on.
In mainstream Sage we are quite late regarding version number anyway.

@jpflori
Copy link
Author

jpflori commented May 11, 2016

Commit: 419bb1b

@jpflori
Copy link
Author

jpflori commented May 11, 2016

Branch: u/jpflori/ntl-9.8.1

@jpflori
Copy link
Author

jpflori commented May 11, 2016

comment:4

Did not run make ptestlong yet but it builds fine.


New commits:

419bb1bUpdate NTL to 9.8.1.

@jpflori
Copy link
Author

jpflori commented May 11, 2016

Author: Jean-Pierre Flori

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

comment:5

OK it should just be straight forward with the exception of disabling cpu specific instructions for binary build. Since I think 9.6.0 ntl does some automatic detection for avx and fma stuff and we will want to turn that off for binary build. The option to pass is NATIVE=off.

Tests pass here with 9.8.0 I cannot imagine 9.8.1 would break anything.

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

Changed author from Jean-Pierre Flori to none

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

Changed branch from u/jpflori/ntl-9.8.1 to none

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

Changed commit from 419bb1b to none

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

Commit: 419bb1b

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

Author: Jean-Pierre Flori

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

Branch: u/jpflori/ntl-9.8.1

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

comment:6

Sorry for the mess, I put the branch back.


New commits:

419bb1bUpdate NTL to 9.8.1.

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

Changed commit from 419bb1b to 85d698c

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

New commits:

85d698cDisable native detection for binary builds. Also make sure that threads are off until further notice

@kiwifb
Copy link
Member

kiwifb commented May 11, 2016

Changed branch from u/jpflori/ntl-9.8.1 to u/fbissey/ntl-9.8.1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 11, 2016

Changed commit from 85d698c to b7a02a1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 11, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b7a02a1fix indentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 12, 2016

Changed commit from b7a02a1 to fde3485

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 12, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

fde3485Avoid a situation where we have an unrecognized option

@jpflori
Copy link
Author

jpflori commented May 12, 2016

Changed author from Jean-Pierre Flori to Jean-Pierre Flori, François Bissey

@jpflori
Copy link
Author

jpflori commented May 12, 2016

comment:10

Thanks François!
I guess we are good to go here.

@jpflori
Copy link
Author

jpflori commented May 12, 2016

Reviewer: François Bissey, Jean-Pierre Flori

@kiwifb
Copy link
Member

kiwifb commented May 12, 2016

comment:11

I just checked, my own doctest run didn't produce any errors. We are ready for early inclusion in 7.3.

@vbraun
Copy link
Member

vbraun commented May 21, 2016

Changed branch from u/fbissey/ntl-9.8.1 to fde3485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants