Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3 print in misc folder #20603

Closed
fchapoton opened this issue May 13, 2016 · 14 comments
Closed

py3 print in misc folder #20603

fchapoton opened this issue May 13, 2016 · 14 comments

Comments

@fchapoton
Copy link
Contributor

another step towards python3 print style, now in the rather large misc folder

CC: @jdemeyer @embray

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 9e3e403

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/20603

@fchapoton fchapoton added this to the sage-7.3 milestone May 13, 2016
@fchapoton
Copy link
Contributor Author

New commits:

89994a3python3 print in misc folder

@fchapoton
Copy link
Contributor Author

Branch: public/20603

@fchapoton
Copy link
Contributor Author

Commit: 89994a3

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 13, 2016

Reviewer: Jori Mäntysalo

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 13, 2016

comment:2

Why I.sort(); print I and not I.sort(); I? Same with for example print N[len(dir):].

You have usually changed continuation line markers, but not in print(kwds) nor in print(af.fix_to_pos()).

Shouldn't print(" ".join(str(i) for i in f)) be print("".join(str(i) for i in f))? Same in src/sage/misc/misc.py.

I will now compile and test.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 13, 2016

comment:3

My R is broken, so I got errors from misc/sageinspect.py and misc/nested_class.pyx. Otherwise I could have marked this as positive review. I hope that someone else can compile and test those two files.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

ca115d3trac 20603 python print in misc folder, details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2016

Changed commit from 89994a3 to ca115d3

@fchapoton
Copy link
Contributor Author

comment:5

These were real failures, due to a line shift in the code.

Let us wait for the next patchbot report

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2016

Changed commit from ca115d3 to 9e3e403

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

9e3e403trac 20603 details

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 13, 2016

comment:7

Replying to @fchapoton:

These were real failures, due to a line shift in the code.

The one in misc/nested_class.pyx. But from sageinspect.py I got "RuntimeError: unable to start r". I am quite sure that your two line change works, but anyways would be nice to have someone else to check those. Might be that I won't do that for following three days.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 14, 2016

comment:8

Got it compiled and tested.

@vbraun
Copy link
Member

vbraun commented May 21, 2016

Changed branch from public/20603 to 9e3e403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants