Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger automake in brial #20634

Closed
sagetrac-gouezel mannequin opened this issue May 19, 2016 · 7 comments
Closed

Do not trigger automake in brial #20634

sagetrac-gouezel mannequin opened this issue May 19, 2016 · 7 comments

Comments

@sagetrac-gouezel
Copy link
Mannequin

sagetrac-gouezel mannequin commented May 19, 2016

Since #20381, brial compilation requires automake in some settings. This is cured by touching suitable files in spkg-install.

Component: build

Author: Sebastien Gouezel

Branch/Commit: 7e31c78

Reviewer: Nathan Dunfield

Issue created by migration from https://trac.sagemath.org/ticket/20634

@sagetrac-gouezel sagetrac-gouezel mannequin added this to the sage-7.3 milestone May 19, 2016
@embray
Copy link
Contributor

embray commented May 20, 2016

comment:1

I haven't tested it directly, but LGTM in principle. Maybe should be a comment there explaining why the touch is needed.

@embray
Copy link
Contributor

embray commented May 20, 2016

comment:2

sage-7.2 hasn't been released already has it? If so this should go in there, otherwise sage 7.2 can't be built without automake.

@jdemeyer
Copy link

comment:3

Sage 7.2 has been released.

But this problem does not trigger always, otherwise we would have seen many more reports. I for one cannot reproduce it. It might be filesystem or OS-dependent.

@NathanDunfield
Copy link

comment:4

I encountered this issue building Sage 7.2 from source on SciLinux 6.7 (an RHEL 6 derivative). Sebastien's patch fixed the problem for me!

@sagetrac-gouezel
Copy link
Mannequin Author

sagetrac-gouezel mannequin commented May 20, 2016

comment:5

Great. I was waiting for feedback before setting it to needs review.

@NathanDunfield
Copy link

Reviewer: Nathan Dunfield

@vbraun
Copy link
Member

vbraun commented May 21, 2016

Changed branch from u/gouezel/no_automake_for_brial to 7e31c78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants