Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print to py3 in data_structures, repl, quadratic_form and dev folders #20643

Closed
fchapoton opened this issue May 21, 2016 · 21 comments
Closed

print to py3 in data_structures, repl, quadratic_form and dev folders #20643

fchapoton opened this issue May 21, 2016 · 21 comments

Comments

@fchapoton
Copy link
Contributor

another small step towards python3 print, getting close to the last one

CC: @jdemeyer @embray @jm58660 @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: b77f47c

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/20643

@fchapoton fchapoton added this to the sage-7.3 milestone May 21, 2016
@fchapoton
Copy link
Contributor Author

Commit: 931d162

@fchapoton
Copy link
Contributor Author

Branch: public/20643

@fchapoton
Copy link
Contributor Author

New commits:

931d162python3 print in data_structures, dev, quadratic_forms and repl

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 21, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b49501epython3 print, details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 21, 2016

Changed commit from 931d162 to b49501e

@fchapoton
Copy link
Contributor Author

comment:3

ok, bot is green, except for the 4 darn failings doctests on my bot (having nothing to do with the present ticket), see #20529

please review

@fchapoton
Copy link
Contributor Author

comment:4

Should I undo the changes to the dev files ? it seems that dev is going to be removed.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 23, 2016

comment:5

Replying to @fchapoton:

Should I undo the changes to the dev files ? it seems that dev is going to be removed.

In what ticket?

@fchapoton
Copy link
Contributor Author

comment:6

#20645

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 23, 2016

comment:7

Now #20645 has already been closed, so it seems clear that you should "rebase" this ticket, i.e. remove dev files.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2016

Changed commit from b49501e to d27d324

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

57cf842Merge branch 'public/20643' into 7.3.b0
d27d324undo any changes to src/sage/dev

@fchapoton
Copy link
Contributor Author

comment:9

done. There may still be a conflict in the next beta, we will see.

@fchapoton fchapoton changed the title print to py3 in data_structures, repl, quadratic_form and dev folders print to py3 in data_structures, repl, quadratic_form folders May 23, 2016
@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 23, 2016

comment:10

OK, I'll review.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 23, 2016

Reviewer: Jori Mäntysalo

@jm58660 jm58660 mannequin changed the title print to py3 in data_structures, repl, quadratic_form folders print to py3 in data_structures, repl, quadratic_form and dev folders May 23, 2016
@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 23, 2016

comment:11

These are not equivalent due to a space:

print "L(" + str(1+2*i) + ", (-4/.)): ", RR . . .
print("L({}, (-4/.)): {}".format(1+2*i, RR . . .

Otherwise I see no problems and I am now compiling and testing. However, a question: what is the meaning of the comma at print('key %s' % (k,))?

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 23, 2016

comment:12

Tests passed and documentation built. Please read my message "Testing and consecutive spaces in output" on sage-devel before changing this to positive_review on behalf of me. Otherwise I found nothing to complain about.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2016

Changed commit from d27d324 to b77f47c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b77f47ctrac 20643 python3 print in quadratic forms, detail

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 23, 2016

comment:14

Ready to go.

@vbraun
Copy link
Member

vbraun commented May 24, 2016

Changed branch from public/20643 to b77f47c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants