New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print to py3 in data_structures, repl, quadratic_form and dev folders #20643
Comments
Commit: |
Branch: public/20643 |
New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
ok, bot is green, except for the 4 darn failings doctests on my bot (having nothing to do with the present ticket), see #20529 please review |
comment:4
Should I undo the changes to the dev files ? it seems that dev is going to be removed. |
comment:5
Replying to @fchapoton:
In what ticket? |
comment:6
|
comment:7
Now #20645 has already been closed, so it seems clear that you should "rebase" this ticket, i.e. remove dev files. |
comment:9
done. There may still be a conflict in the next beta, we will see. |
comment:10
OK, I'll review. |
Reviewer: Jori Mäntysalo |
comment:11
These are not equivalent due to a space:
Otherwise I see no problems and I am now compiling and testing. However, a question: what is the meaning of the comma at |
comment:12
Tests passed and documentation built. Please read my message "Testing and consecutive spaces in output" on sage-devel before changing this to positive_review on behalf of me. Otherwise I found nothing to complain about. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Ready to go. |
Changed branch from public/20643 to |
another small step towards python3 print, getting close to the last one
CC: @jdemeyer @embray @jm58660 @tscrim
Component: python3
Author: Frédéric Chapoton
Branch/Commit:
b77f47c
Reviewer: Jori Mäntysalo
Issue created by migration from https://trac.sagemath.org/ticket/20643
The text was updated successfully, but these errors were encountered: