Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong result for is_subword_of #20687

Closed
dkrenn opened this issue May 26, 2016 · 8 comments
Closed

wrong result for is_subword_of #20687

dkrenn opened this issue May 26, 2016 · 8 comments
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-8.3

Comments

@dkrenn
Copy link
Contributor

dkrenn commented May 26, 2016

I wouldn't have expected the following:

sage: phi = WordMorphism('a->aba,b->ab')
sage: w = phi('a', 3)
sage: w
word: abaababaabaababaababa
sage: Word('bb').is_subword_of(w)
True

Component: combinatorics

Author: Sébastien Labbé

Branch/Commit: c84aeac

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/20687
@dkrenn dkrenn added this to the sage-7.3 milestone May 26, 2016
@seblabbe
Copy link
Contributor

seblabbe commented May 6, 2018

comment:1

By subword is meant the same definition as in Chapter 6 Subwords of 1997 Lothaire's book.

@seblabbe
Copy link
Contributor

seblabbe commented May 6, 2018

Branch: u/slabbe/20687

@seblabbe
Copy link
Contributor

seblabbe commented May 6, 2018

Commit: c84aeac

@seblabbe
Copy link
Contributor

seblabbe commented May 6, 2018

comment:2

I updated the doc.

New commits:

c84aeac20687: added doc to is_subword_of

@seblabbe
Copy link
Contributor

seblabbe commented May 6, 2018

Author: Sébastien Labbé

@seblabbe seblabbe modified the milestones: sage-7.3, sage-8.3 May 6, 2018
@dkrenn
Copy link
Contributor Author

dkrenn commented May 6, 2018

comment:4

LGTM; let's wait for the patchbot. (If the patchbot does not complain, then anyone who sees this, feel free to give it a positive review.)

@dkrenn
Copy link
Contributor Author

dkrenn commented May 6, 2018

Reviewer: Daniel Krenn

@vbraun
Copy link
Member

vbraun commented May 18, 2018

Changed branch from u/slabbe/20687 to c84aeac

@vbraun vbraun closed this as completed in f23c426 May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@vbraun @seblabbe @dkrenn