Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LatticePoset: add is_join_semidistributive #20714

Closed
jm58660 mannequin opened this issue May 30, 2016 · 20 comments
Closed

LatticePoset: add is_join_semidistributive #20714

jm58660 mannequin opened this issue May 30, 2016 · 20 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 30, 2016

This patch will add a function to check if a lattice is join-semidistributive or not.

Backend can also check for meet-semidistributive and give a "certificate", i.e. elements failing the definition of semidistributive. It is not used at this time.

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: b4c99b6

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/20714

@jm58660 jm58660 mannequin added this to the sage-7.3 milestone May 30, 2016
@jm58660 jm58660 mannequin added c: combinatorics labels May 30, 2016
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 30, 2016

Branch: u/jmantysalo/semidistributive

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 30, 2016

Commit: 2e264a7

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 30, 2016

comment:2

Ready for review, or at least for comments. I don't know about examples, but just now can not invent anything better.


New commits:

1e14708Add is_join_semidistributive().
2e264a7Removed spaces.

@jm58660 jm58660 mannequin added the s: needs review label May 30, 2016
@fchapoton
Copy link
Contributor

comment:3

missing doctest continuation here:

+            sage: H = HasseDiagram({0:[1, 2], 1:[3, 4], 2:[4, 5], 3:[6],
+                                    4:[6], 5:[6]})

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 30, 2016

comment:4

And shortcut based on covering relations count is in wrong place.

I don't like this test system that does not detect missing continuation line.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

74777e0Slight modifications.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2016

Changed commit from 2e264a7 to 74777e0

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 30, 2016

comment:6

OK, maybe this works.

It would be a good idea to think about this, not just blindly translate the definition to code. Maybe later.

@jm58660 jm58660 mannequin added s: needs review and removed s: needs work labels May 30, 2016
@fchapoton
Copy link
Contributor

comment:7

typo here:

semidistibutive

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

9145ac9Typo correction

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Changed commit from 74777e0 to 9145ac9

@tscrim
Copy link
Collaborator

tscrim commented May 31, 2016

comment:9

You can also use \neq instead of \not=.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Changed commit from 9145ac9 to 6a3338b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

6a3338bFrom \not= to \neq.

@fchapoton
Copy link
Contributor

comment:11

another typo

semistributivity

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b4c99b6Another typo.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Changed commit from 6a3338b to b4c99b6

@fchapoton
Copy link
Contributor

comment:13

looks good to me.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Jun 2, 2016

Changed branch from u/jmantysalo/semidistributive to b4c99b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants