-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOMFLY polynomial of links. #20719
Comments
New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
I've made some tweaks. We should also test other examples, such as two unknots and the Boromean rings (since those are the (lib)homfly examples). New commits:
|
Changed branch from u/mmarco/homfly_polynomial_of_links_ to u/tscrim/homfly_polynomial-20719 |
Reviewer: Travis Scrimshaw |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
comment:7
We might have a problem:
Some of the signs are wrong in this example. Nathan is thinking it might possibly by a variable Also, I will add a description of the polynomial after the above issue gets resolved. |
comment:8
The problem is that there are many equivalent definitions of the homfly polynomial. All of them are related by a change of variables. The homfly program, which we adapted to libhomfly, uses the one where the variables are called In particular, the first two variables are related by multiplying the variables by It is true that we should clarify which are the coordinates we take. |
Changed branch from u/tscrim/homfly_polynomial-20719 to u/mmarco/homfly_polynomial-20719 |
comment:10
I think this basicallys solves the problem. If you compare the output with |
Changed branch from u/mmarco/homfly_polynomial-20719 to u/tscrim/homfly_polynomial-20719 |
Changed branch from u/tscrim/homfly_polynomial-20719 to u/mmarco/homfly_polynomial-20719 |
Changed branch from u/mmarco/homfly_polynomial-20719 to u/tscrim/homfly_polynomial-20719 |
comment:12
Great; thank you. I've added a note about the normalizations. I've fixed it so this didn't cause a segfault when there is more than one isolated component. I also added the extra little doc I wanted. If you're happy with my changes, then you can set a positive review. New commits:
|
Changed branch from u/tscrim/homfly_polynomial-20719 to u/mmarco/homfly_polynomial-20719 |
New commits:
|
comment:18
Other than a trailing |
Changed branch from u/mmarco/homfly_polynomial-20719 to u/tscrim/homfly_polynomial-20719 |
comment:19
Okay, I made some last little doc tweaks. If you're okay with my changes, then you can set a positive review. New commits:
|
Changed branch from u/tscrim/homfly_polynomial-20719 to u/mmarco/homfly_polynomial-20719 |
Changed branch from u/mmarco/homfly_polynomial-20719 to u/tscrim/homfly_polynomial-20719 |
comment:21
Ups, wrong push, sorry. |
comment:22
I get an error when building documentation. Working on it. |
comment:23
Probably this: |
comment:24
Oh and the indentation is wrong: - ``normalization`` -- (default: ``lm``) the system of coordinates
- and can be one of the following:
+ and can be one of the following: (and for the rest of the block). |
comment:25
Ok, checking it now. If it builds, I will push the branch with the correction and give a positive review. |
comment:26
Replying to @miguelmarco:
Sounds good. Thank you. |
Changed branch from u/tscrim/homfly_polynomial-20719 to u/mmarco/homfly_polynomial-20719 |
New commits:
|
comment:29
There's a few things in the doc I need to tweak. |
comment:30
Okay, that will do it. Thank you for all your work on this. New commits:
|
Changed branch from u/mmarco/homfly_polynomial-20719 to u/tscrim/homfly_polynomial-20719 |
Changed branch from u/tscrim/homfly_polynomial-20719 to |
This branch adds a method for computing the HOMFLY polynomial of links. It deppends on #18057 and #18047.
Depends on #18057
Depends on #18047
CC: @vbraun @kcrisman @sagetrac-amitjadagni @sagetrac-fugelde @tscrim
Component: algebraic topology
Keywords: days74
Author: Miguel Marco
Branch/Commit:
ee2cf38
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/20719
The text was updated successfully, but these errors were encountered: