Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOMFLY polynomial of links. #20719

Closed
miguelmarco opened this issue May 30, 2016 · 50 comments
Closed

HOMFLY polynomial of links. #20719

miguelmarco opened this issue May 30, 2016 · 50 comments

Comments

@miguelmarco
Copy link
Contributor

This branch adds a method for computing the HOMFLY polynomial of links. It deppends on #18057 and #18047.

Depends on #18057
Depends on #18047

CC: @vbraun @kcrisman @sagetrac-amitjadagni @sagetrac-fugelde @tscrim

Component: algebraic topology

Keywords: days74

Author: Miguel Marco

Branch/Commit: ee2cf38

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20719

@miguelmarco
Copy link
Contributor Author

Dependencies: #18057, #18047

@miguelmarco
Copy link
Contributor Author

Branch: u/mmarco/homfly_polynomial_of_links_

@miguelmarco
Copy link
Contributor Author

New commits:

05edf9cAdded homfly_polynomial method.

@miguelmarco
Copy link
Contributor Author

Commit: 05edf9c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Changed commit from 05edf9c to b641799

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b641799Adapted to the new interface by dicts.

@tscrim
Copy link
Collaborator

tscrim commented May 31, 2016

Changed commit from b641799 to da53581

@tscrim
Copy link
Collaborator

tscrim commented May 31, 2016

comment:5

I've made some tweaks. We should also test other examples, such as two unknots and the Boromean rings (since those are the (lib)homfly examples).


New commits:

da53581Some reviewer changes.

@tscrim
Copy link
Collaborator

tscrim commented May 31, 2016

@tscrim
Copy link
Collaborator

tscrim commented May 31, 2016

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 1, 2016

Changed commit from da53581 to 6c45265

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 1, 2016

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

0f880bcset doctests as optional
86b9a43Cython interface to libhomfly
d3e96fcset doctests as optional
69ec550Merge branch 'u/mmarco/libhomfly_interface' of git://trac.sagemath.org/sage into t/18057/libhomfly_interface
2019b9dMoved dependency to cysignals
53ad4bfAdapted to the new interface with functions for strings and dict
eeda425Removing commented out code and making OptionalExtension.
b4c923cMarked all tests as optional, because they all depend on libhomfly.
a4add26Merge branch 'u/tscrim/libhomfly_cython_interface-18057' of trac.sagemath.org:sage into u/tscrim/homfly_polynomial-20719
6c45265Adding some more doctests.

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

comment:7

We might have a problem:

sage: B = BraidGroup(3)
sage: K = Knot(B([-1,-1,-1,-1,-1,-1,-2,1,-2,-2]))  # Knot 9_6
L^10*M^4 - L^8*M^6 - 3*L^10*M^2 + 4*L^8*M^4 + L^6*M^6 + L^10 - 3*L^8*M^2 - 5*L^6*M^4 - L^8 + 7*L^6*M^2 - 3*L^6

Some of the signs are wrong in this example. Nathan is thinking it might possibly by a variable a = -i M and/or b = -i L, but still...

Also, I will add a description of the polynomial after the above issue gets resolved.

@miguelmarco
Copy link
Contributor Author

comment:8

The problem is that there are many equivalent definitions of the homfly polynomial. All of them are related by a change of variables.

The homfly program, which we adapted to libhomfly, uses the one where the variables are called L and M. There are at least other two definitions that use the variables \alpha and z and x, y and z respectively.

In particular, the first two variables are related by multiplying the variables by I, as you said.

It is true that we should clarify which are the coordinates we take.

@miguelmarco
Copy link
Contributor Author

@miguelmarco
Copy link
Contributor Author

comment:10

I think this basicallys solves the problem. If you compare the output with normalization = 'az' to the results shown in knot atlas, they should match.

@miguelmarco
Copy link
Contributor Author

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

Changed commit from 6c45265 to a468291

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

New commits:

df0eef1Handle the other usual normalization.
a468291Correct writing of doctest

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

comment:12

Great; thank you. I've added a note about the normalizations. I've fixed it so this didn't cause a segfault when there is more than one isolated component. I also added the extra little doc I wanted. If you're happy with my changes, then you can set a positive review.


New commits:

5c54442Fixing issue with isolated components.
dd21a96Adding a little bit more documentation.

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

Changed commit from a468291 to dd21a96

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

New commits:

62f87a8Handle several isolated components

@tscrim
Copy link
Collaborator

tscrim commented Jun 1, 2016

comment:18

Other than a trailing ] here: http://mathworld.wolfram.com/HOMFLYPolynomial.html] LGTM. Thank you.

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

Changed commit from 62f87a8 to dcdf428

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

comment:19

Okay, I made some last little doc tweaks. If you're okay with my changes, then you can set a positive review.


New commits:

cd786cbFixing docbuild issue.
5d9bc87Merge branch 'u/tscrim/libhomfly_cython_interface-18057' into u/tscrim/homfly_polynomial-20719
3b4a5deMerge branch 'u/mmarco/homfly_polynomial-20719' of trac.sagemath.org:sage into u/tscrim/homfly_polynomial-20719
dcdf428Some last little doc fixes.

@miguelmarco
Copy link
Contributor Author

@miguelmarco
Copy link
Contributor Author

@miguelmarco
Copy link
Contributor Author

comment:21

Ups, wrong push, sorry.

@miguelmarco
Copy link
Contributor Author

comment:22

I get an error when building documentation. Working on it.

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

comment:23

Probably this: L ^{-1}, which needs to be L^{-1} (and similar for a).

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

comment:24

Oh and the indentation is wrong:

         - ``normalization`` -- (default: ``lm``) the system of coordinates
-            and can be one of the following:
+          and can be one of the following:

(and for the rest of the block).

@miguelmarco
Copy link
Contributor Author

comment:25

Ok, checking it now. If it builds, I will push the branch with the correction and give a positive review.

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

comment:26

Replying to @miguelmarco:

Ok, checking it now. If it builds, I will push the branch with the correction and give a positive review.

Sounds good. Thank you.

@miguelmarco
Copy link
Contributor Author

@miguelmarco
Copy link
Contributor Author

Changed commit from dcdf428 to c9d0987

@miguelmarco
Copy link
Contributor Author

New commits:

c9d0987Fixed docstring

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

comment:29

There's a few things in the doc I need to tweak.

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

Changed commit from c9d0987 to ee2cf38

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

comment:30

Okay, that will do it. Thank you for all your work on this.


New commits:

ee2cf38Last little fixes in the doc.

@tscrim
Copy link
Collaborator

tscrim commented Jun 2, 2016

@vbraun
Copy link
Member

vbraun commented Jun 3, 2016

Changed branch from u/tscrim/homfly_polynomial-20719 to ee2cf38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants