New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LatticePoset: about complements #20727
Comments
Branch: u/jmantysalo/hasse_complements |
Commit: |
New commits:
|
comment:3
Just a If wanted, I can make a patch that only corrects the corner case in |
comment:4
This is essentially a positive review, but I don't know the definition of the complements of elements in a poset. I think it would be good to give this. |
Reviewer: Travis Scrimshaw |
comment:5
Replying to @tscrim:
(I guess you mean lattice and not poset, even if it is easy to extend the definition to every bounded poset.) It is said in In how many places should it be said? In |
comment:6
I think it definitely needs to be defined in For the other ones, I would include a line at the end of each linking to similar/relevant methods (ie, |
comment:7
First, thanks for reviews! Replying to @kevindilks:
This patch will do that. Althought I must admit that now
True. I guess that #20940 will be last of this serie, so it is propably right place to add seealso-links. Before that I wait comment from Travis at #20972. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
OK, I added the definition of complement directly to this function in It feels good design to have "internals" in Now we have |
comment:10
What makes you think it's good design? It seems like poor design to have the code for a single function spread across different files. If somebody is working with a poset/lattice and wants to figure out what this function is doing, instead of |
comment:11
For example series-parallel decomposition should be doable without temporary posets, i.e. using But even having all functions at |
comment:12
Replying to @kevindilks:
You're forgetting the fact that by working in I think we can remove all references to the deprecation because this function is no longer broken AFAIK. |
comment:14
Whoops, that's right, I wanted to the comment about the deprecation removed. |
comment:15
Replying to @tscrim:
But we could have it all in one file, without
OK, I can remove them. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:17
Hmm... There were no deprecations left in my code. But anyway, I guess this can be thinked later. I changed this patch to only correct the corner case error and added tests for that. |
This comment has been minimized.
This comment has been minimized.
comment:18
ok, looks good to me |
Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton |
Changed branch from u/jmantysalo/hasse_complements to |
There is a slight corner-case -error:
will give
{1: [1, 1]}
.CC: @tscrim
Component: combinatorics
Author: Jori Mäntysalo
Branch/Commit:
89dbcf4
Reviewer: Travis Scrimshaw, Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/20727
The text was updated successfully, but these errors were encountered: