Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculus -- get doctest coverage above 50% #2073

Closed
williamstein opened this issue Feb 6, 2008 · 7 comments
Closed

calculus -- get doctest coverage above 50% #2073

williamstein opened this issue Feb 6, 2008 · 7 comments

Comments

@williamstein
Copy link
Contributor

Component: calculus

Issue created by migration from https://trac.sagemath.org/ticket/2073

@williamstein williamstein added this to the sage-2.10.2 milestone Feb 6, 2008
@williamstein williamstein self-assigned this Feb 6, 2008
@williamstein
Copy link
Contributor Author

Attachment: calculus_doctest_improvements.patch.gz

@williamstein
Copy link
Contributor Author

@williamstein
Copy link
Contributor Author

@williamstein
Copy link
Contributor Author

comment:2

Attachment: trac-2073-calculus_coverage_part4.patch.gz

As of patch four, these are the only remaining public (not underscored) functions without proper documentation in the entire calculus directory:


Missing documentation:
         * subs(self, *args, **kwds)
         * substitute_over_ring(self, in_dict=None, ring=None, **kwds)
         * str(self, bits=None)
         * maxima_init(x)
         * sys_init(x, system)
         * var_cmp(x,y)
         * CallableSymbolicExpressionRing(args, check=True)
         * foo(n)
         * args(self)
         * plot(self, *args, **kwds)
         * tex_needs_braces(self)
         * simplify(self)


Missing doctests:
         * obj(self)
         * variables(self, vars=tuple([]))
         * integral(self, x=None, a=None, b=None)
         * expression(self)

@williamstein
Copy link
Contributor Author

comment:4

this is done and ready to be reviewed

@williamstein williamstein changed the title calculus -- get doctest coverage up to 100% calculus -- get doctest coverage above 50% Feb 6, 2008
@mwhansen
Copy link
Contributor

mwhansen commented Feb 7, 2008

comment:5

Attachment: 2073-random-doctests.patch.gz

Positive review after applying the last patch as well.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 7, 2008

comment:6

Applied all five patches to Sage 2.10.2.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Feb 7, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants