Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop argument types from comparison methods in coercion model #20757

Closed
jdemeyer opened this issue Jun 2, 2016 · 7 comments
Closed

Drop argument types from comparison methods in coercion model #20757

jdemeyer opened this issue Jun 2, 2016 · 7 comments
Labels
c: coercion p: major / 3 t: enhancement
Milestone
sage-7.3

Comments

@jdemeyer
Copy link

jdemeyer commented Jun 2, 2016

See #20740 for the rationale.

Depends on #20740
Depends on #20753

Component: coercion

Keywords: days74

Author: Jeroen Demeyer

Branch/Commit: 9943074

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/20757
@jdemeyer jdemeyer added this to the sage-7.3 milestone Jun 2, 2016
@jdemeyer jdemeyer changed the title Drop argument type from single-underscore arithmetic methods Drop argument type from comparison methods Jun 2, 2016
@jdemeyer
Copy link
Author

jdemeyer commented Jun 2, 2016

Branch: u/jdemeyer/drop_argument_type_from_single_underscore_arithmetic_methods

@jdemeyer
Copy link
Author

jdemeyer commented Jun 2, 2016

Commit: 9943074

@jdemeyer
Copy link
Author

jdemeyer commented Jun 2, 2016

New commits:

56776e2Drop return type from single-underscore arithmetic methods
2a5d081Remove unused coerce_to_base_ring() method
9943074Drop argument type from comparison methods

@jdemeyer
Copy link
Author

jdemeyer commented Jun 2, 2016

Changed keywords from none to days74

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Drop argument type from comparison methods Drop argument types from comparison methods in coercion model Jun 15, 2016
@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@vbraun
Copy link
Member

vbraun commented Jun 24, 2016

Changed branch from u/jdemeyer/drop_argument_type_from_single_underscore_arithmetic_methods to 9943074

@vbraun vbraun closed this as completed in bb51c1a Jun 24, 2016
This was referenced Apr 29, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coercion p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.3
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @mezzarobba