New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computing plane curve models for algebraic curves #20790
Comments
Branch: u/gjorgenson/ticket/20790 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
I implemented a function to project affine curves that allows the user to specify coordinates to use in the projection. If the given coordinates yield a projection that doesn't have a curve as its image, an error will be raised. I also implemented a plane_projection function that doesn't take any user input but just tries to find two coordinates that will yield a projection that has a plane curve as its image. I think such a projection should always exist, but right now my approach to finding one is just trying all possible projections to two coordinates. For projective curves, I added some functionality for working with curves defined over finite fields. Now the projection function will test all of the points of the ambient space of a curve over a finite field until it finds a point not on the curve. An error is returned if the curve contains all of the ambient space points. |
comment:5
A few questions:
should be enough to construct both the morphism and the image curve. Something similar could be done for the projective case.
I think that, in general, you could get simpler projections if you start with l[i] = 0 (for instance, most times you will get the projection from point [0:0:...: 0:1].
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Looks good so far. One addition that would be nice os to allow the user to choose the projection point. It may become useful at some point. |
comment:8
By the way, instead of
you can just use
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Thanks, changes made! |
comment:12
Reviewer name |
Reviewer: Miguel Marco |
comment:14
Merge conflict, merge in next beta... |
New commits:
|
comment:23
Ok, the user can now specify an ambient space to project into in each of the projection functions. I also added some input tests. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:25
The projection functions now have tests to show passing an ambient space will ensure the projected curves are defined in that space. |
comment:26
looks good to me. |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:28
Fixed a merge conflict with the imports in affine_curve.py, projective_curve.py. |
comment:30
Merge conflict, probably #21085 |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
comment:32
Ok, fixed the conflict with 21085. I don't think there are any other curve tickets closed after sage 7.4 beta1, so this should be good to go. |
Changed branch from u/gjorgenson/ticket/20790 to |
Given a generic algebraic curve, compute a plane curve birational to it.
CC: @bhutz @miguelmarco
Component: algebraic geometry
Keywords: gsoc2016
Author: Grayson Jorgenson
Branch/Commit:
679338b
Reviewer: Miguel Marco, Ben Hutz
Issue created by migration from https://trac.sagemath.org/ticket/20790
The text was updated successfully, but these errors were encountered: