parse_label() in sage/modular/modform/constructor.py fails in GammaH case

[kevinywlui]

Currently, it does not return index in the GammaH case though the Gamma0 and Gamma1 case does.

In Newform(), both the group and the index is expected L485 in sage/modular/modform/constructor.py

Component: modular forms

Keywords: parse_label, modular_form

Author: Kevin Lui

Branch/Commit: b00abe1

Reviewer: William Stein, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/20823

[kevinywlui]

Branch: u/klui/parse_label___in_sage_modular_modform_constructor_py_fails_in_gammah_case

[kevinywlui]

Commit: 6026e56

[kevinywlui]

New commits:

6026e56

parse_label now returns index

[williamstein]

comment:3

You need to add a doctest illustrating the case that your change addresses.

[sagetrac-git]

Changed commit from 6026e56 to 80166b8

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

80166b8

added docstring, removed blank line at end of file

[kevinywlui]

comment:5

Replying to @williamstein:

You need to add a doctest illustrating the case that your change addresses.

Fixed.

[williamstein]

comment:7

Your docstring is not formatted properly and won't convert correctly to html/sphinx/etc. Please see
http://doc.sagemath.org/html/en/developer/coding_basics.html#template
and especially the double colons.

[sagetrac-git]

Changed commit from 80166b8 to 79e11ab

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

79e11ab

fixed docstring

[kevinywlui]

comment:9

Replying to @williamstein:

Your docstring is not formatted properly and won't convert correctly to html/sphinx/etc. Please see
http://doc.sagemath.org/html/en/developer/coding_basics.html#template
and especially the double colons.

Fixed.

[fchapoton]

comment:11

still not correctly formatted. Lines ending with :: should be followed by an empty line

Please add you real name in the Authors box (here, top of this web page)

[kevinywlui]

Author: Kevin Lui

[sagetrac-git]

Changed commit from 79e11ab to b00abe1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b00abe1

more docstring fixes

[kevinywlui]

comment:14

Replying to @fchapoton:

still not correctly formatted. Lines ending with :: should be followed by an empty line

Please add you real name in the Authors box (here, top of this web page)

Hopefully this time! What's the name for this style of formatting?

[williamstein]

comment:15

Hopefully this time! What's the name for this style of formatting?

Sphinx

[williamstein]

Reviewer: William Stein, chapoton

[williamstein]

comment:17

Looks good to me now.

[fchapoton]

Changed reviewer from William Stein, chapoton to William Stein, Frédéric Chapoton

[vbraun]

Changed branch from u/klui/parse_label___in_sage_modular_modform_constructor_py_fails_in_gammah_case to b00abe1