Old-style packages no longer install

[jdemeyer]

$ ./sage -p chomp
Found package chomp in /usr/local/src/sage-git/upstream/chomp-20130518.p1.spkg
chomp-20130518.p1
====================================================
Extracting package /usr/local/src/sage-git/upstream/chomp-20130518.p1.spkg
-rw-r--r-- 1 jdemeyer jdemeyer 676322 Jun 14 17:17 /usr/local/src/sage-git/upstream/chomp-20130518.p1.spkg
Finished extraction
/usr/local/src/sage-git/build/bin/sage-spkg: line 542: cd: chomp-20130518.p1: No such file or directory
Error: after extracting, the directory chomp-20130518.p1 does not exist

CC: @embray

Component: build

Author: Jeroen Demeyer

Branch/Commit: 43061c8

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/20828

[jdemeyer]

Branch: u/jdemeyer/old_style_packages_no_longer_install

[jdemeyer]

New commits:

43061c8

Fix installing old-style packages

[jdemeyer]

Commit: 43061c8

[embray]

comment:3

Looks fine to me, though I don't really know how "old style packages" are supposed to work. Are none of them tested?

[jdemeyer]

comment:4

Replying to @embray:

Looks fine to me, though I don't really know how "old style packages" are supposed to work.

Doesn't really matter. The only thing this patch does is to keep whatever behaviour was there before.

Are none of them tested?

Old-style packages are never tested, they are never automatically installed anyway.

[videlec]

comment:5

You wrote

    # Old-style package (deprecated)

Why old-style package should be deprecated? I thought that we wanted to support people own spkgs using this format...

[videlec]

comment:6

More precisely: we should not have the list of packages hardcoded into Sage source (is it imposed by the "new-style"?)... there should be an alternative way to install things.

[vbraun]

comment:7

Old style is deprecated. There is sage -pip for an alternative way.

[vbraun]

Reviewer: Volker Braun

[videlec]

comment:8

Replying to @vbraun:

Old style is deprecated. There is sage -pip for an alternative way.

What about a package including C-libraries, databases or executables? As far as I understand, sage -pip is the alternative for python (possibly cython) libraries.

[vbraun]

Changed branch from u/jdemeyer/old_style_packages_no_longer_install to 43061c8