New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new classify_elements() function to refine have_same_parent() #20836
Milestone
Comments
New commits:
|
Commit: |
comment:3
test. |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Travis Scrimshaw |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
Changed branch from u/jdemeyer/add_new_classify_elements___function_to_refine_have_same_parent__ to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The function
have_same_parent(left, right)
is useful and needed to support the coercion model. However, that function not only checks whether parent are equal, but also whetherleft
andright
are bothElement
s and whether they have the same type. This information is checked, but lost whenhave_same_parent
returns.Instead, let us have a function
classify_elements(left, right)
which does the same checks ashave_same_parent()
(so it should be equally efficient), but returns all information.test.
CC: @defeo
Component: coercion
Author: Jeroen Demeyer
Branch/Commit:
c41bc91
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/20836
The text was updated successfully, but these errors were encountered: