Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degree and arithmetic genus for projective curves #20848

Closed
sagetrac-gjorgenson mannequin opened this issue Jun 20, 2016 · 21 comments
Closed

Degree and arithmetic genus for projective curves #20848

sagetrac-gjorgenson mannequin opened this issue Jun 20, 2016 · 21 comments

Comments

@sagetrac-gjorgenson
Copy link
Mannequin

sagetrac-gjorgenson mannequin commented Jun 20, 2016

Implement a function to compute the degree of a projective curve, and generalize the existing arithmetic genus computation for projective plane curves to work for arbitrary projective curves.

CC: @bhutz @miguelmarco

Component: algebraic geometry

Keywords: gsoc2016

Author: Grayson Jorgenson

Branch/Commit: 3427412

Reviewer: Ben Hutz

Issue created by migration from https://trac.sagemath.org/ticket/20848

@sagetrac-gjorgenson sagetrac-gjorgenson mannequin added this to the sage-7.3 milestone Jun 20, 2016
@sagetrac-gjorgenson
Copy link
Mannequin Author

sagetrac-gjorgenson mannequin commented Jun 21, 2016

Branch: u/gjorgenson/ticket/20848

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

0f9621120848: first implementation attempt.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2016

Commit: 0f96211

@miguelmarco
Copy link
Contributor

comment:4

In the case of plane curves, which genus do we want to assignt to non-reduced curves?

@sagetrac-gjorgenson
Copy link
Mannequin Author

sagetrac-gjorgenson mannequin commented Jun 21, 2016

comment:5

Oops, I was under the impression that these definitions agreed for arbitrary plane curves. Is the Hilbert polynomial definition still okay for reducible/non-reduced curves? Would it be better to restrict the genus computations to just irreducible curves?

@bhutz
Copy link

bhutz commented Jun 22, 2016

comment:6

I think genus should be restricted to irreducible. The problem is not the difference between plane and not plane curves. You could have a curve with multiple components of different genus

eg: (y-x)(y2-x2-x-1)

@sagetrac-gjorgenson
Copy link
Mannequin Author

sagetrac-gjorgenson mannequin commented Jun 23, 2016

Changed commit from 0f96211 to 07e6b72

@sagetrac-gjorgenson
Copy link
Mannequin Author

sagetrac-gjorgenson mannequin commented Jun 23, 2016

comment:7

I added an is_irreducible check which checks irreducibility by just counting irreducible components.

The new commit shows up in the log for this ticket but no notification seems to have been generated (I think because of the trac server change).

EDIT: actually the new commit shows up as part of this comment now


New commits:

07e6b7220848: added is_irreducible check

@bhutz
Copy link

bhutz commented Jun 23, 2016

comment:8
  • Just checking the number of components for is_irreducible is not good enough. You're better off checking if the defining ideal is prime.
P.<x,y>=ProjectiveSpace(QQ,1)
X=P.subscheme([x^2])
X.is_irreducible(),X.defining_ideal().is_prime()
  • since the degree is just the dim! times the leading coefficient of HP, why not do it for projective subschemes instead of just curves?

  • Adding an actual REF for Hartshorne would be nice.

@bhutz
Copy link

bhutz commented Jun 23, 2016

Reviewer: Ben Hutz

@sagetrac-gjorgenson
Copy link
Mannequin Author

sagetrac-gjorgenson mannequin commented Jun 24, 2016

Changed commit from 07e6b72 to f4709f5

@sagetrac-gjorgenson
Copy link
Mannequin Author

sagetrac-gjorgenson mannequin commented Jun 24, 2016

comment:9

Thanks, made the changes.


New commits:

f4709f520848: generalized degree computation, and improved is_irreducible

@vbraun
Copy link
Member

vbraun commented Jun 24, 2016

comment:11

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2016

Changed commit from f4709f5 to df1faa6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

df1faa620848: merge with 7.3 beta5.

@vbraun
Copy link
Member

vbraun commented Jun 27, 2016

comment:15

Merge conflict #20839

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

f775a0f20839: first implementation attempt.
e0188ce20839: some changes from review
656472420839: merge with ticket 20774
09eea0220839: some remaining changes from review
4b9ab0a20839: implemented Serre intersection multiplicity for affine/projective subschemes
cae16fe20839: improved is_transverse
342741220848: merge with ticket 20839

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2016

Changed commit from df1faa6 to 3427412

@sagetrac-gjorgenson
Copy link
Mannequin Author

sagetrac-gjorgenson mannequin commented Jun 27, 2016

comment:17

Okay I think the conflict with #20839 is fixed now.

@bhutz
Copy link

bhutz commented Jun 27, 2016

comment:18

still looks fine for me.

@vbraun
Copy link
Member

vbraun commented Jun 29, 2016

Changed branch from u/gjorgenson/ticket/20848 to 3427412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants