Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syndrome decoder for a linear code sometimes sets wrong decoder type #20898

Closed
johanrosenkilde opened this issue Jun 28, 2016 · 10 comments
Closed

Comments

@johanrosenkilde
Copy link
Contributor

There is a bug in how the decoder type is set for the syndrome decoder. Consider

sage: C = codes.HammingCode(GF(5), 3)
sage: D = C.decoder("Syndrome")
sage: C.minimum_distance()
3
sage: D.maximum_error_weight()
1
sage: D.decoder_type()
{'complete', 'hard-decision', 'might-error', 'unique'}

The last line should not have had "might-error" but instead should have had "always-succeed" and "minimum-distance".

CC: @sagetrac-dlucas

Component: coding theory

Keywords: linear code, syndrome, rd3

Author: Clément Pernet

Branch/Commit: f152ea8

Reviewer: Bruno Grenet

Issue created by migration from https://trac.sagemath.org/ticket/20898

@ClementPernet
Copy link
Contributor

Branch: u/cpernet/syndrome_decoder_type

@ClementPernet
Copy link
Contributor

Author: Clément Pernet

@ClementPernet
Copy link
Contributor

comment:2

There was actually 2 bugs: the decoding_radius tested for this decision was not updated with the value found during the construction of the lookup table. Then some set.add needed to be changed.

I also added the ticket's code as a doctest.

Attached branch should fix the pb. Open for review.


New commits:

ffb9bdcfix 2 bugs: the updated max_error_weight was not tested + add->union
6f8bf3cNeed to get the result that union returns
d581d76add #20898 code as a doctest

@ClementPernet
Copy link
Contributor

Changed keywords from linear code, syndrome to linear code, syndrome, rd3

@ClementPernet
Copy link
Contributor

Commit: d581d76

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 7, 2017

Changed commit from d581d76 to f152ea8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 7, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

f152ea8replace union by update

@bgrenet
Copy link

bgrenet commented Feb 7, 2017

Reviewer: Bruno Grenet

@bgrenet
Copy link

bgrenet commented Feb 7, 2017

comment:4

Looks OK!

@vbraun
Copy link
Member

vbraun commented Feb 8, 2017

Changed branch from u/cpernet/syndrome_decoder_type to f152ea8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants